From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: William Breathitt Gray <william.gray@linaro.org>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Migrate i8255 GPIO drivers to regmap API
Date: Mon, 7 Nov 2022 12:37:00 +0200 [thread overview]
Message-ID: <Y2jfzKZkcEcQTdH5@smile.fi.intel.com> (raw)
In-Reply-To: <cover.1667472555.git.william.gray@linaro.org>
On Thu, Nov 03, 2022 at 07:20:46AM -0400, William Breathitt Gray wrote:
> The regmap API supports IO port accessors so we can take advantage of
> regmap abstractions rather than handling access to the device registers
> directly in the driver.
>
> Precursor patches are provided for 104-dio-48e and 104-idi-48 to migrate
> their respective device-specific registers first in order to simplify
> the subsequent patch migrating the i8255 library and its dependents.
>
> The struct i8255 control_state member serves as a cache of the i8255
> device's control register. Does the regmap API support caching such that
> we won't need to manually update a control_state member?
Yes, regmap supports caching and IIRC it's opt-out.
> William Breathitt Gray (3):
> gpio: 104-dio-48e: Migrate to regmap API
> gpio: 104-idi-48: Migrate to regmap API
> gpio: i8255: Migrate to regmap API
>
> drivers/gpio/gpio-104-dio-48e.c | 200 +++++++++++++++++++----------
> drivers/gpio/gpio-104-idi-48.c | 110 +++++++++++-----
> drivers/gpio/gpio-gpio-mm.c | 97 ++++++++++----
> drivers/gpio/gpio-i8255.c | 218 +++++++++++++++++++++-----------
> drivers/gpio/gpio-i8255.h | 54 ++++----
> 5 files changed, 451 insertions(+), 228 deletions(-)
>
>
> base-commit: b8b80348c57b360019071e17380298619c5d8066
> --
> 2.37.3
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-07 10:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 11:20 [PATCH 0/3] Migrate i8255 GPIO drivers to regmap API William Breathitt Gray
2022-11-03 11:20 ` [PATCH 1/3] gpio: 104-dio-48e: Migrate " William Breathitt Gray
2022-11-07 10:38 ` Andy Shevchenko
2022-11-09 20:47 ` William Breathitt Gray
2022-11-03 11:20 ` [PATCH 2/3] gpio: 104-idi-48: " William Breathitt Gray
2022-11-03 11:20 ` [PATCH 3/3] gpio: i8255: " William Breathitt Gray
2022-11-07 10:37 ` Andy Shevchenko [this message]
2022-11-09 20:35 ` [PATCH 0/3] Migrate i8255 GPIO drivers " William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2jfzKZkcEcQTdH5@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox