* [PATCH] drm/panfrost: Remove type name from internal struct again
@ 2022-11-03 11:40 Steven Price
2022-11-07 13:22 ` Alyssa Rosenzweig
0 siblings, 1 reply; 3+ messages in thread
From: Steven Price @ 2022-11-03 11:40 UTC (permalink / raw)
To: Alyssa Rosenzweig
Cc: Steven Price, Rob Herring, Tomeu Vizoso, dri-devel, linux-kernel,
Alyssa Rosenzweig
Commit 72655fb942c1 ("drm/panfrost: replace endian-specific types with
native ones") accidentally reverted part of the parent commit
7228d9d79248 ("drm/panfrost: Remove type name from internal structs")
leading to the situation that the Panfrost UAPI header still doesn't
compile correctly in C++.
Revert the accidental revert and pass me a brown paper bag.
Reported-by: Alyssa Rosenzweig <alyssa@collabora.com>
Fixes: 72655fb942c1 ("drm/panfrost: replace endian-specific types with native ones")
Signed-off-by: Steven Price <steven.price@arm.com>
---
include/uapi/drm/panfrost_drm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_drm.h
index 6f93c915cc88..9f231d40a146 100644
--- a/include/uapi/drm/panfrost_drm.h
+++ b/include/uapi/drm/panfrost_drm.h
@@ -254,7 +254,7 @@ struct panfrost_dump_object_header {
__u64 nbos;
} reghdr;
- struct pan_bomap_hdr {
+ struct {
__u32 valid;
__u64 iova;
__u32 data[2];
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/panfrost: Remove type name from internal struct again
2022-11-03 11:40 [PATCH] drm/panfrost: Remove type name from internal struct again Steven Price
@ 2022-11-07 13:22 ` Alyssa Rosenzweig
2022-11-07 15:47 ` Steven Price
0 siblings, 1 reply; 3+ messages in thread
From: Alyssa Rosenzweig @ 2022-11-07 13:22 UTC (permalink / raw)
To: Steven Price
Cc: Alyssa Rosenzweig, Rob Herring, Tomeu Vizoso, dri-devel,
linux-kernel
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
On Thu, Nov 03, 2022 at 11:40:36AM +0000, Steven Price wrote:
> Commit 72655fb942c1 ("drm/panfrost: replace endian-specific types with
> native ones") accidentally reverted part of the parent commit
> 7228d9d79248 ("drm/panfrost: Remove type name from internal structs")
> leading to the situation that the Panfrost UAPI header still doesn't
> compile correctly in C++.
>
> Revert the accidental revert and pass me a brown paper bag.
>
> Reported-by: Alyssa Rosenzweig <alyssa@collabora.com>
> Fixes: 72655fb942c1 ("drm/panfrost: replace endian-specific types with native ones")
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
> include/uapi/drm/panfrost_drm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_drm.h
> index 6f93c915cc88..9f231d40a146 100644
> --- a/include/uapi/drm/panfrost_drm.h
> +++ b/include/uapi/drm/panfrost_drm.h
> @@ -254,7 +254,7 @@ struct panfrost_dump_object_header {
> __u64 nbos;
> } reghdr;
>
> - struct pan_bomap_hdr {
> + struct {
> __u32 valid;
> __u64 iova;
> __u32 data[2];
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/panfrost: Remove type name from internal struct again
2022-11-07 13:22 ` Alyssa Rosenzweig
@ 2022-11-07 15:47 ` Steven Price
0 siblings, 0 replies; 3+ messages in thread
From: Steven Price @ 2022-11-07 15:47 UTC (permalink / raw)
To: Alyssa Rosenzweig
Cc: Alyssa Rosenzweig, Rob Herring, Tomeu Vizoso, dri-devel,
linux-kernel
On 07/11/2022 13:22, Alyssa Rosenzweig wrote:
> Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Thanks, pushed to drm-misc-fixes:
c4299907c09a drm/panfrost: Remove type name from internal struct again
Steve
> On Thu, Nov 03, 2022 at 11:40:36AM +0000, Steven Price wrote:
>> Commit 72655fb942c1 ("drm/panfrost: replace endian-specific types with
>> native ones") accidentally reverted part of the parent commit
>> 7228d9d79248 ("drm/panfrost: Remove type name from internal structs")
>> leading to the situation that the Panfrost UAPI header still doesn't
>> compile correctly in C++.
>>
>> Revert the accidental revert and pass me a brown paper bag.
>>
>> Reported-by: Alyssa Rosenzweig <alyssa@collabora.com>
>> Fixes: 72655fb942c1 ("drm/panfrost: replace endian-specific types with native ones")
>> Signed-off-by: Steven Price <steven.price@arm.com>
>> ---
>> include/uapi/drm/panfrost_drm.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_drm.h
>> index 6f93c915cc88..9f231d40a146 100644
>> --- a/include/uapi/drm/panfrost_drm.h
>> +++ b/include/uapi/drm/panfrost_drm.h
>> @@ -254,7 +254,7 @@ struct panfrost_dump_object_header {
>> __u64 nbos;
>> } reghdr;
>>
>> - struct pan_bomap_hdr {
>> + struct {
>> __u32 valid;
>> __u64 iova;
>> __u32 data[2];
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-07 15:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-03 11:40 [PATCH] drm/panfrost: Remove type name from internal struct again Steven Price
2022-11-07 13:22 ` Alyssa Rosenzweig
2022-11-07 15:47 ` Steven Price
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox