Re: [RFC v2 3/3] mm, printk: introduce new format %pGt for page_type

Joe Perches
2022-11-06T18:04:40Z

On Sun, 2022-11-06 at 23:03 +0900, Hyeonggon Yoo wrote:
> dump_page() uses %pGp format to print 'flags' field of struct page.
> As some page flags (e.g. PG_buddy, see page-flags.h for more details)
> are set in page_type field, introduce %pGt format which provides
> human readable output of page_type. And use it in dump_page().
[]
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
[]
> @@ -2056,6 +2056,28 @@ char *format_page_flags(char *buf, char *end, unsigned long flags)
> return buf;
> }
>
> +static

noinline_for_stack ?

> +char *format_page_type(char *buf, char *end, unsigned int page_type)
> +{
> + if (!(page_type & PAGE_TYPE_BASE))
> + return string(buf, end, "no type for user-mapped page", default_str_spec);

Might be better with something like '%pGt: no type..."