Re: [PATCH v5 7/7] riscv: configs: defconfig: Enable Renesas RZ/Five SoC

Geert Uytterhoeven
2022-11-09T07:47:14Z

Hi Prabhakar,

On Tue, Nov 8, 2022 at 11:05 PM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> On Tue, Nov 8, 2022 at 7:20 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Tue, Nov 8, 2022 at 6:23 PM Lad, Prabhakar
> > <prabhakar.csengg@gmail.com> wrote:
> > > On Tue, Nov 8, 2022 at 4:12 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > On Tue, Nov 8, 2022 at 5:07 PM Lad, Prabhakar
> > > > <prabhakar.csengg@gmail.com> wrote:
> > > > > On Tue, Nov 8, 2022 at 3:52 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > > > On Fri, Oct 28, 2022 at 6:59 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > > > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > > > > >
> > > > > > > Enable Renesas RZ/Five SoC config in defconfig. It allows the default
> > > > > > > upstream kernel to boot on RZ/Five SMARC EVK board.
> > > > > > >
> > > > > > > Alongside enable SERIAL_SH_SCI config so that the serial driver used by
> > > > > > > RZ/Five SoC is built-in.
> > > > > > >
> > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > > > > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> > > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > > > > ---
> > > > > > > v4 -> v5
> > > > > > > * No change
> > > > > > >
> > > > > > > v3 -> v4
> > > > > > > * Explicitly enabled ARCH_R9A07G043 config (note I have restored the RB
> > > > > > > tags with this change)
> > > > > > > * Used riscv instead of RISC-V in subject line
> > > > > >
> > > > > > Thanks for the update!
> > > > > >
> > > > > > > --- a/arch/riscv/configs/defconfig
> > > > > > > +++ b/arch/riscv/configs/defconfig
> > > > > > > @@ -29,6 +29,8 @@ CONFIG_SOC_MICROCHIP_POLARFIRE=y
> > > > > > > CONFIG_SOC_SIFIVE=y
> > > > > > > CONFIG_SOC_STARFIVE=y
> > > > > > > CONFIG_SOC_VIRT=y
> > > > > > > +CONFIG_ARCH_RENESAS=y
> > > > > > > +CONFIG_ARCH_R9A07G043=y
> > > > > >
> > > > > > You forgot to refresh after moving ARCH_RENESAS in v5 of "riscv:
> > > > > > Kconfig.socs: Add ARCH_RENESAS kconfig option", and after relying on
> > > > > > ARCH_R9A07G043 in drivers/soc/renesas/Kconfig.
> > > > > >
> > > > > Sorry I missed your point here, could you please elaborate.
> > > >
> > > > I mean that the options have moved, so you should update
> > > > your patch like this:
> > > >
> > > Ouch got that.
> > >
> > > > --- a/arch/riscv/configs/defconfig
> > > > +++ b/arch/riscv/configs/defconfig
> > > > @@ -26,11 +26,10 @@ CONFIG_EXPERT=y
> > > > # CONFIG_SYSFS_SYSCALL is not set
> > > > CONFIG_PROFILING=y
> > > > CONFIG_SOC_MICROCHIP_POLARFIRE=y
> > > > +CONFIG_ARCH_RENESAS=y
> > > > CONFIG_SOC_SIFIVE=y
> > > > CONFIG_SOC_STARFIVE=y
> > > > CONFIG_SOC_VIRT=y
> > > > -CONFIG_ARCH_RENESAS=y
> > > > -CONFIG_ARCH_R9A07G043=y
> > > > CONFIG_SMP=y
> > > > CONFIG_HOTPLUG_CPU=y
> > > > CONFIG_PM=y
> > > > @@ -163,6 +159,7 @@ CONFIG_MAILBOX=y
> > > > CONFIG_RPMSG_CHAR=y
> > > > CONFIG_RPMSG_CTRL=y
> > > > CONFIG_RPMSG_VIRTIO=y
> > > > +CONFIG_ARCH_R9A07G043=y
> > > > CONFIG_EXT4_FS=y
> > > > CONFIG_EXT4_FS_POSIX_ACL=y
> > > > CONFIG_EXT4_FS_SECURITY=y
> > > >
> > > > > > > CONFIG_SMP=y
> > > > > > > CONFIG_HOTPLUG_CPU=y
> > > > > > > CONFIG_PM=y
> > > > > >
> > > > > > PM and GPIOLIB are auto-selected by ARCH_R9A07G043 (through ARCH_RZG2L)
> > > > > > resp. SOC_RENESAS, so they can be dropped. But it's better to do this
> > > > > > after the release of v6.2-rc1, when all pieces have fallen together.
> > > > > >
> > > > > Are you suggesting dropping it from defconfig?
> > > >
> > > > Yes, but not right now, as that would make it depend on my
> > > > renesas-drivers-for-v6.2 branch to keep them enabled.
> > > >
> ^^^
> > > I was wondering if that's required by other platforms though.
> > > CONFIG_PM was added for VIRT machine and GPIOLIB for HiFive.
> >
> > Does that matter? They would still get it, as long as they use the
> > defconfig.
> >
> Confused, didnt you say about dropping it from defconfig...

Yes, I did, but not right now, only after v6.2-rc1.

- Once the defconfig has CONFIG_ARCH_R9A07G043=y, ARCH_RZG2L will
be auto-selected (commit ebd0e06f3063cc2e ("soc: renesas: Identify
RZ/Five SoC") is already upstream), and CONFIG_PM as well. So there
is no longer a need for the defconfig to enable it explicitly.
- Once the defconfig has CONFIG_ARCH_RENESAS=y, SOC_RENESAS will
be auto-selected, but auto-selecting CONFIG_GPIOLIB depends on commit
b3acbca3c80e6124 ("soc: renesas: Kconfig: Explicitly select GPIOLIB and
PINCTRL config under SOC_RENESAS") is only in renesas-drivers-for-v6.2.

Please run "make savedefconfig", and compare the generated defconfig
with arch/riscv/configs/defconfig.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds