From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9922CC433FE for ; Mon, 7 Nov 2022 18:20:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233142AbiKGSUQ (ORCPT ); Mon, 7 Nov 2022 13:20:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233133AbiKGST6 (ORCPT ); Mon, 7 Nov 2022 13:19:58 -0500 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FA6424964 for ; Mon, 7 Nov 2022 10:19:29 -0800 (PST) Received: by mail-pg1-x52a.google.com with SMTP id s196so11179920pgs.3 for ; Mon, 07 Nov 2022 10:19:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=w7oQlQSGWErcIWmEijXaEvWPIfe56DxtjW2YodF6ZaE=; b=dral5VrDzWpIXTVIhpxyg4cWdu7i694XTx/CtLfAwwl9xnXJw/FNSm8HnbZ+uu1YsQ yzUabaLL/Wcw35lXOJyRUAf4lIYf51cyXMFoNHeJy7AVQ+376aM8en6Il5jJuLibCMas zLH5pw0Yl8eZ7dH3ihR//thkLoLSylcvErhF6x10I6yvnF3yfwEZ7aWOawqm0x6MDe6T NFAe+2RAo1zQrcwTAdDBnY/o5n31RmMMScKrAwj+xgbLXSkgDjbv+G+nhQ54v/df8TA1 dVR7wgrXZtuz0UAJT2klX38uJSfKodmXM/uWCkf+m92aaZxca0pwYQwdF5SajPz+pdUV /9nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w7oQlQSGWErcIWmEijXaEvWPIfe56DxtjW2YodF6ZaE=; b=nGLd7QvlOgcSe/EGGFmF6ts3DD8ZkmlNynow+hXVQWFndvpYx5soeM9ocmHmRXsmKZ O7OjvNpCWzrsSpKOtpCzIT5wguzLrPSAhe09UFp7Mqn0XfmboYpj+a4R2JKL/KS6Ll1V KwXTvP/yOceBj87ixGRt6duYDTCzEHbdGsLvc7Cu6WYXI/gYKzcR/T/N/oMji9Iy/5M2 M/3J7UjtHltWWW0w37+wOfNwwCLb5Aqrb9CSc4nVuibrtTYqiXapIFeZfKfXS7qTDOhv FpzH1mcweCpzIiXe1fze/JJ0AHSMYNRCN4Uv+QFpBLMMWKTbDI8UmqFEtTaS5dIq1KOK ITAw== X-Gm-Message-State: ACrzQf39tZ19I2S9XJBmv1mXTomAVGqnuwhWGQlfwx8bxP7vUL6ASkiq hwolo285u1ntzf/Cat2plljyjA== X-Google-Smtp-Source: AMsMyM4rnkRsDtAGEb3zfh89py2cnTFpfYi1YlUckPJ0bJYEmer59wywHW7N5IxQ+TKIT8759KckpQ== X-Received: by 2002:a63:8a42:0:b0:46f:5804:8d9e with SMTP id y63-20020a638a42000000b0046f58048d9emr44691332pgd.214.1667845168931; Mon, 07 Nov 2022 10:19:28 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id e9-20020a170902784900b00183e2a96414sm5288040pln.121.2022.11.07.10.19.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 10:19:28 -0800 (PST) Date: Mon, 7 Nov 2022 18:19:25 +0000 From: Sean Christopherson To: David Matlack Cc: Andrew Jones , "Wang, Wei W" , "pbonzini@redhat.com" , "vipinsh@google.com" , "ajones@ventanamicro.com" , "eric.auger@redhat.com" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 00/18] KVM selftests code consolidation and cleanup Message-ID: References: <20221024113445.1022147-1-wei.w.wang@intel.com> <20221028124106.oze32j2lkq5ykifj@kamzik> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 07, 2022, David Matlack wrote: > On Fri, Oct 28, 2022 at 8:49 AM Sean Christopherson wrote: > > Anyways, if someone wants to pursue this, these ideas and the "requirement" should > > be run by the checkpatch maintainers. They have far more experience and authority > > in this area, and I suspect we aren't the first people to want checkpatch to get > > involved in enforcing shortlog scope. > > Documenting would at least be an improvement over what we have today > since it would eliminate the need to re-explain the preferred rules > every time. We can just point to the documentation when reviewing > patches. Agreed. And there are many other things I want to formalize for KVM x86, e.g. testing expectations, health requirements for the various branches, what each branch is used for etc... If you want to send a patch for the shortlogs thing, maybe create Documentation/process/maintainer-kvm-x86.rst and link it into Documentation/process/maintainer-handbooks.rst? > `git log --pretty=oneline` is not a great way to document shortlog > scopes because it does not explain the rules (e.g. when to use "KVM: > x86: " vs "KVM: x86/mmu: "), does not explain why things the way they > are, and is inconsistent since we don't always catch every patch that > goes by with a non-preferred shortlog scope.