Re: [PATCH 09/30] ACPI: sysfs: Use kstrtobool() instead of strtobool()

Rafael J. Wysocki
2022-11-03T18:48:39Z

On Wed, Nov 2, 2022 at 12:33 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Nov 01, 2022 at 10:13:57PM +0100, Christophe JAILLET wrote:
> > strtobool() is the same as kstrtobool().
> > However, the latter is more used within the kernel.
> >
> > In order to remove strtobool() and slightly simplify kstrtox.h, switch to
> > the other function name.
> >
> > While at it, include the corresponding header file (<linux/kstrtox.h>)
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> > This patch is part of a serie that axes all usages of strtobool().
> > Each patch can be applied independently from the other ones.
> >
> > The last patch of the serie removes the definition of strtobool().
> >
> > You may not be in copy of the cover letter. So, if needed, it is available
> > at [1].
> >
> > [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/
> > ---
> > drivers/acpi/sysfs.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c
> > index cc2fe0618178..2d81c742e4d2 100644
> > --- a/drivers/acpi/sysfs.c
> > +++ b/drivers/acpi/sysfs.c
> > @@ -9,6 +9,7 @@
> > #include <linux/bitmap.h>
> > #include <linux/init.h>
> > #include <linux/kernel.h>
> > +#include <linux/kstrtox.h>
> > #include <linux/moduleparam.h>
> >
> > #include "internal.h"
> > @@ -992,7 +993,7 @@ static ssize_t force_remove_store(struct kobject *kobj,
> > bool val;
> > int ret;
> >
> > - ret = strtobool(buf, &val);
> > + ret = kstrtobool(buf, &val);
> > if (ret < 0)
> > return ret;
> >
> > --

Applied as 6.2 material, thanks!