Re: [PATCH 18/30] module: Use kstrtobool() instead of strtobool()

Aaron Tomlin
2022-11-06T15:04:15Z

On Tue 2022-11-01 22:14 +0100, Christophe JAILLET wrote:
> strtobool() is the same as kstrtobool().
> However, the latter is more used within the kernel.
>
> In order to remove strtobool() and slightly simplify kstrtox.h, switch to
> the other function name.
>
> While at it, include the corresponding header file (<linux/kstrtox.h>)
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This patch is part of a serie that axes all usages of strtobool().
> Each patch can be applied independently from the other ones.
>
> The last patch of the serie removes the definition of strtobool().
>
> You may not be in copy of the cover letter. So, if needed, it is available
> at [1].
>
> [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/
> ---
> kernel/module/main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index ff2dfd1f548d..79e17522e196 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -17,6 +17,7 @@
> #include <linux/fs.h>
> #include <linux/kernel.h>
> #include <linux/kernel_read_file.h>
> +#include <linux/kstrtox.h>
> #include <linux/slab.h>
> #include <linux/vmalloc.h>
> #include <linux/elf.h>
> @@ -2649,7 +2650,7 @@ static int unknown_module_param_cb(char *param, char *val, const char *modname,
> int ret;
>
> if (strcmp(param, "async_probe") == 0) {
> - if (strtobool(val, &mod->async_probe_requested))
> + if (kstrtobool(val, &mod->async_probe_requested))
> mod->async_probe_requested = true;
> return 0;
> }
> --
> 2.34.1
>

Reviewed-by: Aaron Tomlin <atomlin@atomlin.com>

--
Aaron Tomlin