Re: [PATCH 03/30] irqchip: Use kstrtobool() instead of strtobool()

Christophe JAILLET
2022-11-26T15:17:05Z

Le 26/11/2022 à 13:46, Marc Zyngier a écrit :
> On Tue, 01 Nov 2022 21:13:51 +0000,
> Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
>>
>> strtobool() is the same as kstrtobool().
>> However, the latter is more used within the kernel.
>>
>> In order to remove strtobool() and slightly simplify kstrtox.h, switch to
>> the other function name.
>>
>> While at it, include the corresponding header file (<linux/kstrtox.h>)
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>> This patch is part of a serie that axes all usages of strtobool().
>> Each patch can be applied independently from the other ones.
>>
>> The last patch of the serie removes the definition of strtobool().
>>
>> You may not be in copy of the cover letter. So, if needed, it is available
>> at [1].
>>
>>
>> This patch has NOT been compile tested.
>
> Thanks for having the honesty to state that this hasn't been even
> compile tested. However, and for fairly obvious reason, I will not
> take such patches.

Ok, so, with a sucessful:
sudo apt install libc6-armel-cross libc6-dev-armel-cross
binutils-arm-linux-gnueabi libncurses5-dev build-essential bison flex
libssl-dev bc
sudo apt install gcc-arm-linux-gnueabi g++-arm-linux-gnueabi

make ARCH=arm CROSS_COMPILE=/usr/bin/arm-linux-gnueabi- -j7 allmodconfig

patch -p1 < strtobool.diff

make ARCH=arm CROSS_COMPILE=/usr/bin/arm-linux-gnueabi- -j7
./drivers/irqchip/irq-gic.o
make ARCH=arm CROSS_COMPILE=/usr/bin/arm-linux-gnueabi- -j7
./drivers/irqchip/irq-gic-v3.o

can I make you change your mind?

CJ

>
> Thanks,
>
> M.
>