From: Peter Zijlstra <peterz@infradead.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Kim Phillips <kim.phillips@amd.com>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Joao Martins <joao.m.martins@oracle.com>,
Jonathan Corbet <corbet@lwn.net>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
David Woodhouse <dwmw@amazon.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Juergen Gross <jgross@suse.com>, Tony Luck <tony.luck@intel.com>,
Babu Moger <Babu.Moger@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
kvm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] x86/speculation: Support Automatic IBRS
Date: Tue, 8 Nov 2022 09:06:50 +0100 [thread overview]
Message-ID: <Y2oOGoh6wBdmG16k@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <da41d7f0-68ea-0c21-1dca-218f8184a0f3@intel.com>
On Mon, Nov 07, 2022 at 03:41:03PM -0800, Dave Hansen wrote:
> On 11/7/22 14:39, Kim Phillips wrote:
> > I've started a version that has AUTOIBRS reuse SPECTRE_V2_EIBRS
> > spectre_v2_mitigation enum, but, so far, it's change to bugs.c
> > looks bigger: 58 lines changed vs. 34 (see below).
> >
> > Let me know if you want me to send it as a part of a v2 submission
> > after I take care of the kvm CPUID review.
>
> Thanks for putting that together. I generally like how this looks.
>
> I think it probably goes to a _bit_ too much trouble to turn off
> "eibrs,lfence/retpoline". If someone goes to the trouble of specifying
> those, a warning or pr_info() is probably enough. You don't need to
> actively override it.
Not, even, just do it. User told you to, it's not technically
impossible, so just go.
next prev parent reply other threads:[~2022-11-08 8:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 21:36 [PATCH 0/3] x86/speculation: Support Automatic IBRS Kim Phillips
2022-11-04 21:36 ` [PATCH 1/3] x86/cpufeatures: Add support for cpuid leaf 80000021/EAX (FeatureExt2Eax) Kim Phillips
2022-11-04 21:48 ` Borislav Petkov
2022-11-15 23:10 ` Kim Phillips
2022-11-16 11:59 ` Borislav Petkov
2022-11-16 20:22 ` Sean Christopherson
2022-11-16 21:01 ` Borislav Petkov
2022-11-04 21:36 ` [PATCH 2/3] x86/speculation: Support Automatic IBRS Kim Phillips
2022-11-04 21:52 ` Borislav Petkov
2022-11-05 11:10 ` Peter Zijlstra
2022-11-07 22:39 ` Kim Phillips
2022-11-07 23:41 ` Dave Hansen
2022-11-08 8:06 ` Peter Zijlstra [this message]
2022-11-11 12:09 ` Borislav Petkov
2022-11-11 12:40 ` Thadeu Lima de Souza Cascardo
2022-11-12 0:46 ` Kim Phillips
2022-11-12 0:54 ` Jim Mattson
2022-11-05 11:39 ` David Laight
2022-11-07 22:40 ` Kim Phillips
2022-11-04 21:36 ` [PATCH 3/3] x86/speculation: Support Automatic IBRS under virtualization Kim Phillips
2022-11-04 22:00 ` Jim Mattson
2022-11-07 22:29 ` Kim Phillips
2022-11-07 22:42 ` Jim Mattson
2022-11-08 22:48 ` Kim Phillips
2022-11-08 22:59 ` Jim Mattson
2022-11-06 8:38 ` Paolo Bonzini
2022-11-04 22:06 ` [PATCH 0/3] x86/speculation: Support Automatic IBRS Dave Hansen
2022-11-07 22:43 ` Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2oOGoh6wBdmG16k@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Babu.Moger@amd.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=joao.m.martins@oracle.com \
--cc=kim.phillips@amd.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox