Re: [PATCH v1 2/2] at_hdmac: return actual status when txstatus parameter is NULL

Tudor.Ambarus
2022-11-08T11:51:30Z

On 11/8/22 09:49, Andy Shevchenko wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> There is no point to return DMA_ERROR if txstatus parameter is NULL. It's a
> valid case and should be handled correspondingly.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/dma/at_hdmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index a9d8dd990d6e..4035d5438530 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -1679,7 +1679,7 @@ atc_tx_status(struct dma_chan *chan,
> if (!txstate) {
> if (test_bit(ATC_IS_PAUSED, &atchan->status))
> return DMA_PAUSED;
> - return DMA_ERROR;
> + return dma_status;

oh, I see you do it here, please squash this patch to the previous one,
you introduced DMA_ERROR in the previous patch.

> }
>
> spin_lock_irqsave(&atchan->vc.lock, flags);
> --
> 2.35.1
>

--
Cheers,
ta