From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Gilles BULOZ <gilles.buloz@kontron.com>
Subject: Re: [PATCH 1/1] serial: 8250_dma: Rearm DMA Rx if more data is pending
Date: Tue, 8 Nov 2022 14:57:34 +0200 [thread overview]
Message-ID: <Y2pSPspgnx+YkBJH@smile.fi.intel.com> (raw)
In-Reply-To: <Y2jsqNHQ5KhYISb3@smile.fi.intel.com>
On Mon, Nov 07, 2022 at 01:31:52PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 07, 2022 at 12:21:26PM +0200, Ilpo Järvinen wrote:
...
> Yep, I used to have something like draft of the below change locally.
> Thanks for putting it in shape and upstreamimg!
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
...
> > -static void __dma_rx_complete(void *param)
> > +static void __dma_rx_complete(struct uart_8250_port *p)
> > {
> > - struct uart_8250_port *p = param;
> > struct uart_8250_dma *dma = p->dma;
Btw, looking into my patch in archives I noticed that dma can also be passed as
a parameter...
...
> > +static void dma_rx_complete(void *param)
> > +{
> > + struct uart_8250_port *p = param;
> > + struct uart_8250_dma *dma = p->dma;
...since you have it already here.
> > + unsigned long flags;
> > +
> > + __dma_rx_complete(p);
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-11-08 12:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 10:21 [PATCH 1/1] serial: 8250_dma: Rearm DMA Rx if more data is pending Ilpo Järvinen
2022-11-07 11:31 ` Andy Shevchenko
2022-11-08 12:57 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2pSPspgnx+YkBJH@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gilles.buloz@kontron.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox