From: Eric Biggers <ebiggers@kernel.org>
To: Alexander Potapenko <glider@google.com>
Cc: syzbot <syzbot+9767be679ef5016b6082@syzkaller.appspotmail.com>,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
tytso@mit.edu
Subject: Re: [syzbot] KMSAN: uninit-value in pagecache_write
Date: Tue, 8 Nov 2022 09:41:30 -0800 [thread overview]
Message-ID: <Y2qUylpsZcJ7HF0Z@sol.localdomain> (raw)
In-Reply-To: <CAG_fn=VPvdHxQc3xm5xkqgFq3uo5oTU_w5vyMj-qQD7DvwQ4BA@mail.gmail.com>
On Tue, Nov 08, 2022 at 10:08:36AM +0100, 'Alexander Potapenko' via syzkaller-bugs wrote:
> > >
> > > Anyway, this patch doesn't hurt, I suppose. Can please you send it out as a
> > > formal patch to linux-ext4? It would be easy for people to miss this patch
> > > buried in this thread. Also, can you please send a patch to linux-f2fs-devel
> > > for the same code in fs/f2fs/verity.c?
> >
> > Will do!
>
> Shall I also initialize fsdata here:
>
> $ git grep 'void \*fsdata;'
> fs/affs/file.c: void *fsdata;
> fs/ext4/verity.c: void *fsdata;
> fs/f2fs/verity.c: void *fsdata;
> fs/hfs/extent.c: void *fsdata;
> fs/hfsplus/extents.c: void *fsdata;
> fs/ocfs2/mmap.c: void *fsdata;
Yes, it looks like they all need this. Except maybe ocfs2? It's hard to tell.
- Eric
next prev parent reply other threads:[~2022-11-08 17:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 9:10 [syzbot] KMSAN: uninit-value in pagecache_write syzbot
2022-11-07 9:46 ` Alexander Potapenko
2022-11-07 17:56 ` Eric Biggers
2022-11-07 18:14 ` Alexander Potapenko
2022-11-08 9:08 ` Alexander Potapenko
2022-11-08 17:41 ` Eric Biggers [this message]
2022-11-10 11:01 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2qUylpsZcJ7HF0Z@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=glider@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+9767be679ef5016b6082@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox