From: Ashok Raj <ashok.raj@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML Mailing List <linux-kernel@vger.kernel.org>,
X86-kernel <x86@kernel.org>, Tony Luck <tony.luck@intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Arjan van de Ven <arjan.van.de.ven@intel.com>,
Andy Lutomirski <luto@kernel.org>,
"Jacon Jun Pan" <jacob.jun.pan@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Kai Huang" <kai.huang@intel.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
"Ashok Raj" <ashok.raj@intel.com>
Subject: Re: [v2 01/13] x86/microcode/intel: Prevent printing updated microcode rev multiple times
Date: Tue, 8 Nov 2022 15:06:20 -0800 [thread overview]
Message-ID: <Y2rg7OYkhtTWQVNL@a4bf019067fa.jf.intel.com> (raw)
In-Reply-To: <Y2lSyX+YS51dxAnr@zn.tnic>
Hi Boris,
On Mon, Nov 07, 2022 at 07:47:37PM +0100, Borislav Petkov wrote:
> On Mon, Nov 07, 2022 at 04:12:59PM +0000, Ashok Raj wrote:
> > Only missing is the ucode date, not a big deal missing it.
>
> Yes, it isn't. One can find it out another way:
>
> $ iucode-tool -l /lib/firmware/intel-ucode/06-9c-00
> microcode bundle 1: /lib/firmware/intel-ucode/06-9c-00
> selected microcodes:
> 001/001: sig 0x000906c0, pf_mask 0x01, 2022-02-19, rev 0x24000023, size 20480
> ^^^^^^^^^^
That's correct, my thought as well. Did you get a chance to review rest of
the patches?
Thought I'll wait for more comments before I send the next rev.
Patch2 is a simple fix that you suggested.
Patch3 is a bug fix. I suspect some earlier upstream reports of ucode
failure after update (early loading) might be related. The symptom is
similar, but those are too old to followup. I got into a similare situation
when i tried to update an incompatible uCode from initrd and system hung.
I'm not positive, but seems highly likely. The following are early loading
failures, not late loading.
https://bugs.launchpad.net/ubuntu/+source/intel-microcode/+bug/1911959
https://forums.linuxmint.com/viewtopic.php?p=1827032#1827032
https://askubuntu.com/questions/1291486/boot-crash-after-latest-update-of-intel-microcode-nov-11-2020
Patch 4 is also a bugfix, today when we reload the same ucode even though
nothing changes it seems to think some feature is new. When i added some
more debug it turned out SGX was probably turned off by OS, but enumerated
by microcode. So it always reports
Cheers,
Ashok
next prev parent reply other threads:[~2022-11-08 23:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 17:58 [v2 00/13] Make microcode late loading more robust Ashok Raj
2022-11-03 17:58 ` [v2 01/13] x86/microcode/intel: Prevent printing updated microcode rev multiple times Ashok Raj
2022-11-04 11:00 ` Borislav Petkov
2022-11-04 13:53 ` Van De Ven, Arjan
2022-11-04 15:52 ` Borislav Petkov
2022-11-04 18:28 ` Ashok Raj
2022-11-04 20:21 ` Borislav Petkov
2022-11-06 13:35 ` Borislav Petkov
2022-11-07 4:17 ` Ashok Raj
2022-11-07 16:12 ` Ashok Raj
2022-11-07 18:47 ` Borislav Petkov
2022-11-08 23:06 ` Ashok Raj [this message]
2022-11-08 23:32 ` Dave Hansen
2022-11-09 9:18 ` Borislav Petkov
2022-12-03 13:51 ` [tip: x86/microcode] x86/microcode/intel: Do not print microcode revision and processor flags tip-bot2 for Ashok Raj
2022-11-03 17:58 ` [v2 02/13] x86/microcode/intel: Print old and new rev after early microcode update Ashok Raj
2022-11-03 17:58 ` [v2 03/13] x86/microcode/intel: Fix a hang if early loading microcode fails Ashok Raj
2022-11-09 11:25 ` Borislav Petkov
2022-11-09 16:07 ` Ashok Raj
2022-11-09 23:34 ` Borislav Petkov
2022-11-03 17:58 ` [v2 04/13] x86/microcode: Fix microcode_check() compare after a new uCode update Ashok Raj
2022-11-03 17:58 ` [v2 05/13] x86/microcode: Move late-load warning to earlier where kernel taint happens Ashok Raj
2022-11-03 17:58 ` [v2 06/13] x86/ipi: Support sending NMI_VECTOR as self ipi Ashok Raj
2022-11-03 17:58 ` [v2 07/13] x86/microcode: Place siblings in NMI loop while update in progress Ashok Raj
2022-11-03 17:58 ` [v2 08/13] x86/mce: Warn of a microcode update is in progress when MCE arrives Ashok Raj
2022-11-03 17:58 ` [v2 09/13] x86/microcode/intel: Add minimum required revision to microcode header Ashok Raj
2022-11-03 17:58 ` [v2 10/13] x86/microcode: Add a generic mechanism to declare support for minrev Ashok Raj
2022-11-03 17:58 ` [v2 11/13] x86/microcode/intel: Drop wbinvd() from microcode loading Ashok Raj
2022-11-03 17:59 ` [v2 12/13] x86/microcode: Display revisions only when update is successful Ashok Raj
2022-11-03 17:59 ` [v2 13/13] x86/microcode/intel: Add ability to update microcode even if rev is unchanged Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2rg7OYkhtTWQVNL@a4bf019067fa.jf.intel.com \
--to=ashok.raj@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=arjan.van.de.ven@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=jacob.jun.pan@intel.com \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox