From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E66CC4332F for ; Wed, 9 Nov 2022 13:50:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230350AbiKINuH (ORCPT ); Wed, 9 Nov 2022 08:50:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230265AbiKINt6 (ORCPT ); Wed, 9 Nov 2022 08:49:58 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CE9F72B1AD for ; Wed, 9 Nov 2022 05:49:50 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA56B1FB for ; Wed, 9 Nov 2022 05:49:56 -0800 (PST) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 594A63F73D for ; Wed, 9 Nov 2022 05:49:50 -0800 (PST) Date: Wed, 9 Nov 2022 13:49:38 +0000 From: Liviu Dudau To: Danilo Krummrich Cc: daniel@ffwll.ch, airlied@linux.ie, tzimmermann@suse.de, mripard@kernel.org, brian.starkey@arm.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH drm-misc-next v4 0/4] drm/arm/hdlcd: use drm managed resources Message-ID: References: <20221026153431.72033-1-dakr@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 08, 2022 at 08:57:55PM +0100, Danilo Krummrich wrote: > Hi Liviu, Hi, > > > The only issue that I'm seeing that is not critical is that at reboot/shutdown time > > I'm getting an "Unexpected global fault, this could be serious" from the smmu: > > > > [ 6893.467910] arm-smmu 7fb30000.iommu: disabling translation > > [ 6893.473550] ohci-platform 7ffb0000.usb: Removing from iommu group 1 > > [ 6893.479909] ehci-platform 7ffc0000.usb: Removing from iommu group 1 > > [ 6893.486931] arm-smmu 7fb10000.iommu: disabling translation > > [ 6893.492521] hdlcd 7ff50000.hdlcd: Removing from iommu group 3 > > [ 6893.492650] arm-smmu 7fb10000.iommu: Unexpected global fault, this could be serious > > [ 6893.505959] arm-smmu 7fb10000.iommu: GFSR 0x80000001, GFSYNR0 0x00000000, GFSYNR1 0x00000000, GFSYNR2 0x00000000 > > [ 6893.516511] arm-smmu 7fb00000.iommu: disabling translation > > [ 6893.522195] dma-pl330 7ff00000.dma-controller: Removing from iommu group 2 > > [ 6893.529607] arm-smmu 2b500000.iommu: disabling translation > > [ 6893.535221] pcieport 0000:00:00.0: Removing from iommu group 0 > > [ 6893.541135] pci 0000:01:00.0: Removing from iommu group 0 > > [ 6893.546604] pcieport 0000:02:01.0: Removing from iommu group 0 > > [ 6893.552511] pcieport 0000:02:02.0: Removing from iommu group 0 > > [ 6893.558418] pcieport 0000:02:03.0: Removing from iommu group 0 > > [ 6893.564329] pcieport 0000:02:0c.0: Removing from iommu group 0 > > [ 6893.570393] pcieport 0000:02:10.0: Removing from iommu group 0 > > [ 6893.576314] pcieport 0000:02:1f.0: Removing from iommu group 0 > > [ 6893.582214] sata_sil24 0000:03:00.0: Removing from iommu group 0 > > [ 6893.588270] sky2 0000:08:00.0: Removing from iommu group 0 > > [ 6893.594616] reboot: Power down > > > > > > The reboot/shutdown succeeds, so I'm not too worried about it for now, but hope that > > this is something you'll keep in mind in the later series when you do drm_dev_unplug(). > > Yes, I'd expect this to be related to the missing protection of platform > device bound resources. > > > > > With that, for the whole series: > > > > Acked-by: Liviu Dudau > > > > Thanks for the patience and going through the series iterations with me. > > > > I can pull this series into drm-misc-next on Monday if you don't have any other plans. > Thanks, I saw you already applied the series. > > Have you had a look on the same series for malidp? Yes, I've looked at the code and it looks reasonable, I just wanted to run it once through the minimum of tests that I use, which involves switching some FPGA images around. Hope to do that today or tomorrow. Best regards, Liviu > > - Danilo > > > > > Best regards, > > Liviu > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯