From: Thierry Reding <thierry.reding@gmail.com>
To: Petlozu Pravareshwar <petlozup@nvidia.com>
Cc: jonathanh@nvidia.com, p.zabel@pengutronix.de,
dmitry.osipenko@collabora.com, ulf.hansson@linaro.org,
kkartik@nvidia.com, cai.huoqing@linux.dev, spatra@nvidia.com,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] soc/tegra: pmc: Add IO Pad table for tegra234
Date: Thu, 10 Nov 2022 02:40:33 +0100 [thread overview]
Message-ID: <Y2xWkRcsDo7FdAo4@orome> (raw)
In-Reply-To: <20220930160213.2447099-1-petlozup@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
On Fri, Sep 30, 2022 at 04:02:13PM +0000, Petlozu Pravareshwar wrote:
> Add IO PAD table for tegra234 to allow configuring dpd mode
> and switching the pins to 1.8V or 3.3V as needed.
>
> In tegra234, DPD registers are reorganized such that there is
> a DPD_REQ register and a DPD_STATUS register per pad group.
> This change accordingly updates the PMC driver.
>
> Signed-off-by: Petlozu Pravareshwar <petlozup@nvidia.com>
> ---
> v3->v4:
> * Addressing the review comments from Thierry Reding.
> v4->v5:
> * Remove dpd request and status variables from "struct tegra_pmc_regs"
> as they are no longer needed.
> v5->v6:
> * Fix compilation warning: unused variable.
> ---
> drivers/soc/tegra/pmc.c | 708 +++++++++++++++++++++++++---------------
> 1 file changed, 439 insertions(+), 269 deletions(-)
Applied, with slight fixups to the commit message.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-11-10 1:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 16:02 [PATCH v6] soc/tegra: pmc: Add IO Pad table for tegra234 Petlozu Pravareshwar
2022-11-10 1:40 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2xWkRcsDo7FdAo4@orome \
--to=thierry.reding@gmail.com \
--cc=cai.huoqing@linux.dev \
--cc=dmitry.osipenko@collabora.com \
--cc=jonathanh@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=petlozup@nvidia.com \
--cc=spatra@nvidia.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox