From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17CAAC433FE for ; Thu, 10 Nov 2022 04:41:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232100AbiKJElS (ORCPT ); Wed, 9 Nov 2022 23:41:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230323AbiKJElN (ORCPT ); Wed, 9 Nov 2022 23:41:13 -0500 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28469252B4 for ; Wed, 9 Nov 2022 20:41:11 -0800 (PST) Received: from letrec.thunk.org ([12.139.153.3]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 2AA4eDSA015823 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 9 Nov 2022 23:40:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1668055221; bh=qahc/OEJv9l/mG+aZHuyYNKbJOQinUkMTYXdNij93nY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=H3rKGqs0uCOsyfC9KYcBFj5CT1PnOFkol1Da9cLF93kcK4GjWwIb4VNfWJdesVNEg Cdr9oSbhuRVO8ki8qwPUuKnBpCxQJsfpFkddNmkJJ+9d+C1uC/z2KZlpFGAe8ek/sS kZ3npSqLafM+NPI4uSE2a5ppEmJuC0I7Hpo5Ov8C5WTOFXTpBpvT5OHsepFbSe3VVW IiPKzfvHAVUhHpZX0J833tJat9qVPGbbHQ4s4IEHM85S9VYCUuNRCQ6oE5o2SZbSm2 F58yi2GCow4Dq7RALHQ7lJ3aOoxRkYTHqz9N25O+TJ/F0ft0CiTT+/V6Zc/hML1stF tjRfXross+zlw== Received: by letrec.thunk.org (Postfix, from userid 15806) id 38BDE8C01E8; Wed, 9 Nov 2022 23:40:13 -0500 (EST) Date: Wed, 9 Nov 2022 23:40:13 -0500 From: "Theodore Ts'o" To: Aaro Koskinen Cc: Linus Torvalds , Paul Cercueil , vbabka@suse.cz, 42.hyeyoo@gmail.com, akpm@linux-foundation.org, catalin.marinas@arm.com, cl@linux.com, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, penberg@kernel.org, rientjes@google.com, rkovhaev@gmail.com, roman.gushchin@linux.dev, willy@infradead.org Subject: Re: Deprecating and removing SLOB Message-ID: References: <20221109234832.GE307514@darkstar.musicnaut.iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221109234832.GE307514@darkstar.musicnaut.iki.fi> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2022 at 01:48:32AM +0200, Aaro Koskinen wrote: > > Some of the reported SLOB issues have been actually real driver bugs, > that go unnoticed when SLUB/SLAB are used (unless perhaps debug stuff > is enabled). I'm not saying kernel should keep SLOB, but it's good at > failing early when there is a bug. See e.g. commit 120ee599b5bf ("staging: > octeon-usb: prevent memory corruption") Out of curiosity, are these bugs that would have been found using KASAN or some of the other kernel sanitizers and/or other debugging tools we have at our disposal? - Ted