From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 217FDC43217 for ; Thu, 10 Nov 2022 07:15:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232816AbiKJHPT (ORCPT ); Thu, 10 Nov 2022 02:15:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232749AbiKJHMA (ORCPT ); Thu, 10 Nov 2022 02:12:00 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 248932648; Wed, 9 Nov 2022 23:11:59 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 27C6F80C7; Thu, 10 Nov 2022 07:02:09 +0000 (UTC) Date: Thu, 10 Nov 2022 09:11:56 +0200 From: Tony Lindgren To: Mark Jackson Cc: Andreas Kemnade , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH] Update Nanobone Message-ID: References: <20221004143901.130935-1-mpfj@newflow.co.uk> <20221108194742.0d9340f4@aktux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Mark Jackson [221109 14:35]: > On Wed, 9 Nov 2022 at 07:37, Tony Lindgren wrote: > > > > The separate defconfig should not be needed. Please send any defconfig > > changes to multi_v7_defconfig or omap2plu_defconfig as separate patches. > > > > Note that you can run make savedefconfig first to produce a minimal diff. > > Then if adding device drivers, please add them as loadable modules where > > possible. > > But using the omap2plus_defconfig increases my kernel to 4.7MB > > My "custom" one has been specifically designed for the NANO platform > and currently sits at about 3.7MB (which nicely fits into the ~4MB memory > bank allocated to the kernel) > > Hence the use of my custom defconfig. Maybe host your defconfig somewhere on a device related wiki page? We got rid of the board specific config files in the kernel years ago in favor of just a few generic ones. > I don't have modules enabled as the platform functionality is pretty fixed. OK nothing wrong with that, multi_v7_defconfig and omap2plus_defconfig are trying to be more generic and distro friendly. > The defconfig I posted was created using savedefconfig. > Is it still wrong ? Nothing wrong with that, except it should be hosted with the device related documentation and not in the kernel :) Regards, Tony