From: Andrew Lunn <andrew@lunn.ch>
To: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Tan Tee Min <tee.min.tan@intel.com>,
Lay Kuan Loon <kuan.loon.lay@intel.com>,
Ong Boon Leong <boon.leong.ong@intel.com>,
Looi Hong Aun <hong.aun.looi@intel.com>,
Voon Weifeng <weifeng.voon@intel.com>,
Zulkifli Muhammad Husaini <muhammad.husaini.zulkifli@intel.com>,
Gan Yi Fang <yi.fang.gan@intel.com>
Subject: Re: [PATCH net v2 RESEND 1/1] net: phy: dp83867: Fix SGMII FIFO depth for non OF devices
Date: Thu, 10 Nov 2022 14:09:13 +0100 [thread overview]
Message-ID: <Y2z3+QlfgpSFNbXm@lunn.ch> (raw)
In-Reply-To: <20221110054938.925347-1-michael.wei.hong.sit@intel.com>
On Thu, Nov 10, 2022 at 01:49:38PM +0800, Michael Sit Wei Hong wrote:
> Current driver code will read device tree node information,
> and set default values if there is no info provided.
>
> This is not done in non-OF devices leading to SGMII fifo depths being
> set to the smallest size.
>
> This patch sets the value to the default value of the PHY as stated in the
> PHY datasheet.
>
> Fixes: 4dc08dcc9f6f ("net: phy: dp83867: introduce critical chip default init for non-of platform")
> Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
https://www.spinics.net/lists/netdev/msg858366.html
When sending a new version, please add any Acked-by, or Reviewed-by
tags you have received. It helps get your patch merged if it can
easily be seen is has been reviewed.
Andrew
next prev parent reply other threads:[~2022-11-10 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 5:49 [PATCH net v2 RESEND 1/1] net: phy: dp83867: Fix SGMII FIFO depth for non OF devices Michael Sit Wei Hong
2022-11-10 13:09 ` Andrew Lunn [this message]
2022-11-12 5:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2z3+QlfgpSFNbXm@lunn.ch \
--to=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=hong.aun.looi@intel.com \
--cc=kuan.loon.lay@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael.wei.hong.sit@intel.com \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tee.min.tan@intel.com \
--cc=weifeng.voon@intel.com \
--cc=yi.fang.gan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox