From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8E4F7C433FE
	for <linux-kernel@archiver.kernel.org>; Thu, 10 Nov 2022 09:29:05 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229917AbiKJJ3E (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 10 Nov 2022 04:29:04 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52486 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229517AbiKJJ3C (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Nov 2022 04:29:02 -0500
Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66F0723B
        for <linux-kernel@vger.kernel.org>; Thu, 10 Nov 2022 01:29:01 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id A932BB8213E
        for <linux-kernel@vger.kernel.org>; Thu, 10 Nov 2022 09:28:59 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D85EEC433C1;
        Thu, 10 Nov 2022 09:28:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1668072538;
        bh=sbmxJc8wws+3m5vuLlHf4AETn9J4RwdFQ2nudh9xbZU=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=xcfebiooVBBkdvyMzUX5mGgQkLsrO1s7wwggogsFJ0QusfZiDJJv4fGJutBn153d/
         zz8trLlv4i9ya5gW+qwTCaLbAz0QvSxYOD/TgGWWN2ajoUYvuIAuS9zHuOJ3YwkGYw
         gxscbuGldSgsPYtjgzAZp3h0RbUpo1Ont0DsHlvI=
Date:   Thu, 10 Nov 2022 10:28:55 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Jacob Bai <jacob.bai.au@gmail.com>
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] staging: rtl8192e: rename r8192E_hwimg.c/h to
 table.c/h
Message-ID: <Y2zEV0kBNSKLBXDt@kroah.com>
References: <cover.1667723306.git.jacob.bai.au@gmail.com>
 <9bb563727915e3f3edd863837608336b99564462.1667723306.git.jacob.bai.au@gmail.com>
 <Y2p0dNLBqiWFPzB9@kroah.com>
 <Y2yt6ERX3szKn2W7@jacob-Ubuntu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y2yt6ERX3szKn2W7@jacob-Ubuntu>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 10, 2022 at 06:53:12PM +1100, Jacob Bai wrote:
> On Tue, Nov 08, 2022 at 04:23:32PM +0100, Greg KH wrote:
> > On Sun, Nov 06, 2022 at 07:31:17PM +1100, Jacob Bai wrote:
> > > Same as other rtlwifi drivers, use table.c/h.
> > 
> > You say what you do here, but not why.
> > 
> > Why rename the file?  What's wrong with the existing name?  It's not
> > causing any problems, right?
> > 
> > thanks,
> > 
> > greg k-h
> >
> No, it's not causing problems. As we are trying to move this driver out
> of staging folder, so I checked how current drivers naming
> files/variables, turns out they all named those two files as table.c/h.
> Maybe we can do the file renaming as the last step.

There are lots of other issues in this driver to cause it not to be able
to be moved out of staging at the moment.  The name of these files is
not one of those issues from what I can tell.

thanks,

greg k-h