From: Dan Carpenter <error27@gmail.com>
To: Jacob Bai <jacob.bai.au@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] staging: rtl8192e: replace macro defines with variables
Date: Thu, 10 Nov 2022 14:07:03 +0300 [thread overview]
Message-ID: <Y2zbV6xDUGPv8mVY@kadam> (raw)
In-Reply-To: <354847ce7b2f9ea4dc549bf13656192c1db7c231.1668075486.git.jacob.bai.au@gmail.com>
On Thu, Nov 10, 2022 at 09:35:11PM +1100, Jacob Bai wrote:
> -u32 RTL8192E_PHY_REG_1T2R_ARRAY[RTL8192E_PHY_REG_1T2R_ARRAY_LEN] = {
> +u32 RTL8192E_PHY_REG_1T2R_ARRAY[] = {
> 0x800, 0x00000000,
> 0x804, 0x00000001,
> 0x808, 0x0000fc00,
> @@ -158,8 +159,9 @@ u32 RTL8192E_PHY_REG_1T2R_ARRAY[RTL8192E_PHY_REG_1T2R_ARRAY_LEN] = {
> 0xe18, 0x161a1a1a,
> 0xe1c, 0x12121416,
> };
> +u32 RTL8192E_PHY_REG_1T2R_ARRAY_LEN = ARRAY_SIZE(RTL8192E_PHY_REG_1T2R_ARRAY);
This patch is kind of a headache to review. I have to go through and
count 148 array elements to ensure that the array hasn't changed size.
But the first patch renames all these arrays, so I first have go back
to patch #1 to find the original name. It might be easier to do the
renames afterward.
Also the commit message should say something like "I have checked the
object code and there is no change at all" or "I have counted all these
array elements and there is no change to the size of the array."
regards,
dan carpenter
next prev parent reply other threads:[~2022-11-10 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 10:35 [PATCH v5 0/2] staging: rtl8192e: trivial code cleanup patches Jacob Bai
2022-11-10 10:35 ` [PATCH v5 1/2] staging: rtl8192e: rename tables in r8192e_hwimg.c Jacob Bai
2022-11-10 11:24 ` Dan Carpenter
2022-11-10 10:35 ` [PATCH v5 2/2] staging: rtl8192e: replace macro defines with variables Jacob Bai
2022-11-10 11:01 ` Dan Carpenter
2022-11-10 11:07 ` Dan Carpenter [this message]
2022-11-10 19:09 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2zbV6xDUGPv8mVY@kadam \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacob.bai.au@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox