From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Aleksey Romanov <AVRomanov@sberdevices.ru>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Johannes Weiner <hannes@cmpxchg.org>,
"minchan@kernel.org" <minchan@kernel.org>,
"ngupta@vflare.org" <ngupta@vflare.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel <kernel@sberdevices.ru>,
Dmitry Rokosov <DDRokosov@sberdevices.ru>
Subject: Re: [RFC PATCH v1 0/4] Introduce merge identical pages mechanism
Date: Wed, 23 Nov 2022 13:13:55 +0900 [thread overview]
Message-ID: <Y32eA93V7w1Wu3VH@google.com> (raw)
In-Reply-To: <20221122121413.ssieckg523urj37h@cab-wsm-0029881.lan>
On (22/11/22 12:14), Aleksey Romanov wrote:
> > IIRC that was patent in question:
> >
> > https://patentimages.storage.googleapis.com/e2/66/9e/0ddbfae5c182ac/US9977598.pdf
>
> I think the patent is talking about "mapping the virtual address" (like
> in KSM). But zram works with the "handle" abstraction, which is a boxed
> pointer to the required object. I think my implementation and the patent
> is slightly different.
>
> Also, the patent speaks of "compressing" pages. In this case, we can add
> zs_merge() function (like zs_compact()), that is, remove the merge logic
> at the allocator level. zsmalloc doesn't say anything about what objects
> it can work with. Implementation at the zsmalloc level is possible,
> though more complicated that at the zram level.
>
> I believe that we can implement at least one of the options I proposed.
>
> What do you think?
Oh, yeah, I'm not saying that we cannot have something like that
in zram/zsmalloc, just wanted to give some historical retrospective
on this and point at some implementation details that should be
considered.
next prev parent reply other threads:[~2022-11-23 4:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 19:00 [RFC PATCH v1 0/4] Introduce merge identical pages mechanism Alexey Romanov
2022-11-21 19:00 ` [RFC PATCH v1 1/4] zram: introduce " Alexey Romanov
2022-11-23 8:25 ` Chen Wandun
2022-11-23 9:04 ` Aleksey Romanov
2022-11-21 19:00 ` [RFC PATCH v1 2/4] zram: add merge sysfs knob Alexey Romanov
2022-11-21 19:00 ` [RFC PATCH v1 3/4] zram: add pages_merged counter to mm_stat Alexey Romanov
2022-11-21 19:00 ` [RFC PATCH v1 4/4] zram: recompression: add ZRAM_MERGED check Alexey Romanov
2022-11-21 20:44 ` [RFC PATCH v1 0/4] Introduce merge identical pages mechanism Johannes Weiner
2022-11-22 3:00 ` Sergey Senozhatsky
2022-11-22 3:07 ` Sergey Senozhatsky
2022-11-22 12:14 ` Aleksey Romanov
2022-11-23 4:13 ` Sergey Senozhatsky [this message]
2022-11-23 8:53 ` Dmitry Rokosov
2022-12-01 10:14 ` Dmitry Rokosov
2022-12-01 10:47 ` Sergey Senozhatsky
2022-12-01 11:14 ` Dmitry Rokosov
2022-12-01 13:29 ` Sergey Senozhatsky
2023-01-11 14:00 ` Alexey Romanov
2023-02-06 10:37 ` Sergey Senozhatsky
2022-11-23 9:07 ` Aleksey Romanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y32eA93V7w1Wu3VH@google.com \
--to=senozhatsky@chromium.org \
--cc=AVRomanov@sberdevices.ru \
--cc=DDRokosov@sberdevices.ru \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel@sberdevices.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox