From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC821C433FE for ; Wed, 23 Nov 2022 21:22:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235288AbiKWVWM (ORCPT ); Wed, 23 Nov 2022 16:22:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237811AbiKWVWI (ORCPT ); Wed, 23 Nov 2022 16:22:08 -0500 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAA5F60695 for ; Wed, 23 Nov 2022 13:22:06 -0800 (PST) Received: by mail-qk1-x733.google.com with SMTP id p18so13372140qkg.2 for ; Wed, 23 Nov 2022 13:22:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VHgVq5sX90/a/BhOqlHy581ALJwbQnSRnRpBrgLVdZ4=; b=fELMiNAAnzjxMhrhiZt4CATnthWy6giZnkz2zXGp5/6n8EoC1LuU8oQfUfEcVQoLA/ QichA/k207xrB80yyoNaf6+Tc6xJWRMTitzk6yAa5opT9pLOQT8wvAuJEAXSJePCzD1w P1cHz58W5dAAqh7AjcFl5B+evStoCtfUo/QXjnjllQ2Q64hRJfOI0JNS7wJdfKKTg9Xw pIr4EV4lXRRTewtoWKmDfsV/KVTYBib80VzDNbshHWyjyAUJnzLjamQI1lZwjr3d5Oo3 LEr00TLTaUa5wfDOmxqWAXothKMITL8f1kDbUtzGHBJDRgCkI2aXdf/FUy+cJ5cKtYnu K3mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VHgVq5sX90/a/BhOqlHy581ALJwbQnSRnRpBrgLVdZ4=; b=67QJiHKVwrgd0uWxgLylxzRPPd+9mBlkjnjSfeRrQa3D3xHqnYLOt5USN9tcFShiV/ H1auOettVvQ5HxZYYK2mSCfR9upFy8Q7aQCtUQkHjD4yvz757xQnJ/94ghOWTxpa3Zm0 96sf/fBgowqKU5KsASdQ9HGepReJXfoAyzsP8NRRG+nlW599o5jHL0kN1meI15VBhAPL EpmlVreco4CHDTCFAUL5FGHYRvQ/BVDYRH6l81CubRWm3XDaMfoeY4Ankd0UAFE56mu8 swbiRLJj3xK/dKLRv5nXtPin3l05/la9Ro8luGn1x1MZKsZrKdfnjSkKqIKAiAph022a 0avA== X-Gm-Message-State: ANoB5pn2ZxiQKY5C6dJWuh4nZrUaX2IC3+tZI2k3rjP5NVPJjPOFvY6K EvnaI4QUtlqZvj4owqNDVxpOcQ== X-Google-Smtp-Source: AA0mqf6Fm5ciQ4wtKxYph7OV6JtS/phXFgRnDvE6jcyPWG1R+idx88hHtrCa8QNdTRhn8Fb+kIVYhg== X-Received: by 2002:a05:620a:10b4:b0:6fb:f17e:c8f8 with SMTP id h20-20020a05620a10b400b006fbf17ec8f8mr16670583qkk.404.1669238526028; Wed, 23 Nov 2022 13:22:06 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:bc4]) by smtp.gmail.com with ESMTPSA id c12-20020ac8054c000000b003995f6513b9sm10148797qth.95.2022.11.23.13.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 13:22:05 -0800 (PST) Date: Wed, 23 Nov 2022 16:22:31 -0500 From: Johannes Weiner To: Yu Zhao Cc: Ivan Babrou , Linux MM , Linux Kernel Network Developers , linux-kernel , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Eric Dumazet , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Paolo Abeni , cgroups@vger.kernel.org, kernel-team Subject: Re: Low TCP throughput due to vmpressure with swap enabled Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 22, 2022 at 05:44:44PM -0700, Yu Zhao wrote: > Hi Johannes, > > Do you think it makes sense to have the below for both the baseline and > MGLRU or it's some behavior change that the baseline doesn't want to > risk? It looks good to me. Besides the new FMODE_NOREUSE, it's also a nice cleanup on the rmap side! It would just be good to keep the comment from folio_referenced_one() and move it to the vma_has_locality() check in invalid_folio_referenced_vma(). Otherwise, Acked-by: Johannes Weiner