From: Conor Dooley <conor.dooley@microchip.com>
To: Deepak Gupta <debug@rivosinc.com>
Cc: Conor Dooley <conor@kernel.org>,
<linux-riscv@lists.infradead.org>, <palmer@dabbelt.com>,
<linux-kernel@vger.kernel.org>, <paul.walmsley@sifive.com>,
Guo Ren <guoren@kernel.org>, Jisheng Zhang <jszhang@kernel.org>
Subject: Re: [PATCH] riscv: VMAP_STACK overflow detection thread-safe
Date: Thu, 24 Nov 2022 07:39:25 +0000 [thread overview]
Message-ID: <Y38frY5H5mjCMvDR@wendy> (raw)
In-Reply-To: <20221124072346.GB1149630@debug.ba.rivosinc.com>
On Wed, Nov 23, 2022 at 11:23:46PM -0800, Deepak Gupta wrote:
> On Thu, Nov 24, 2022 at 06:30:35AM +0000, Conor Dooley wrote:
> > On 24 November 2022 00:50:06 GMT, Deepak Gupta <debug@rivosinc.com> wrote:
> > For stack traces, especially long ones, please cut out the timestamps.
> I followed formatting of stack traces in commit 31da94c25ae. Assumed since
> that's merged, that's how test and stack traces should be included in commit
> msg.
>
> I'll follow your suggestion and remove timestamps.
It's just nice for the reader, since the timestamps are pretty much
noise. But it's not a "you must do this", unlike having correct Fixes:
formatting etc.
HTH,
Conor.
prev parent reply other threads:[~2022-11-24 7:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 0:50 [PATCH] riscv: VMAP_STACK overflow detection thread-safe Deepak Gupta
2022-11-24 1:32 ` Guo Ren
2022-11-24 8:26 ` Deepak Gupta
2022-11-24 9:07 ` Deepak Gupta
[not found] ` <CAJF2gTQ=Vr6neABtz9JSCei6oPEsyWTpb-Y=Rxt5jy6n1VEtGA@mail.gmail.com>
2022-11-24 5:56 ` Deepak Gupta
2022-11-24 6:31 ` Guo Ren
2022-11-24 7:10 ` Deepak Gupta
2022-11-24 8:59 ` Conor Dooley
2022-11-24 9:10 ` Deepak Gupta
2022-11-24 9:36 ` Guo Ren
2022-11-24 6:30 ` Conor Dooley
2022-11-24 7:23 ` Deepak Gupta
2022-11-24 7:39 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y38frY5H5mjCMvDR@wendy \
--to=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=debug@rivosinc.com \
--cc=guoren@kernel.org \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox