From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79781C4332F for ; Sun, 13 Nov 2022 13:08:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235330AbiKMNIu (ORCPT ); Sun, 13 Nov 2022 08:08:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233794AbiKMNIq (ORCPT ); Sun, 13 Nov 2022 08:08:46 -0500 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEAE66451 for ; Sun, 13 Nov 2022 05:08:44 -0800 (PST) Received: by mail-ot1-x32c.google.com with SMTP id a7-20020a056830008700b0066c82848060so5278163oto.4 for ; Sun, 13 Nov 2022 05:08:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zyETYDiRN3VplmbENm82U2H3FCfTggZYLpOpQqSk3NE=; b=cIQBkZ6n8OcicnSebegRPdcOnfQdOIpwaqsw4zQcmRNIcyrZsAYJ5gkwO7Ib7QsC5T JGmSSAnoRIkOHcUnFuZabglwSnks7TdzHCMQPoRI0mtYhcGe8NdPHPMruw18+1lPcEht bvWBCTZcMxB/3YVDfqVTLpw8kBgBUPlNCOUNGmuG8lCVQwEo4XT3LG1WONOUiOwd4XGF 1hBk3t9IgNoiwTYo1IMt/DDxiXHupTvMniix2/lv4fybpmL6EigPKgo5oMV5XR+K6fB0 w2Zsnowbydj/WfBr1qyPIuVcpeMecU/zIPfS98KpQKMolKZ9qbUDQoqNpvLHT6imB3II V3GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zyETYDiRN3VplmbENm82U2H3FCfTggZYLpOpQqSk3NE=; b=HLrkFhXRvBG88EVvhk3lmZtLJUBWR6OzIEmatI5JzwziGyEC5r+tl0+BZXwEl6o736 7Fx0VlzdlqRpjN/pqY6g1efy4fiWEqf4Y8H2n8Mx0svCFGTgqBJ8BjslLLF8Bkg6GLKX S/w+aC5J62r8er1btlJCBKTssmL35LzgW9ojxDhc83bXWbrHm9EiJilF0FERfcSJQSgM U+dsdVRh6cYPWcKvCvs9XAnba0pSOVRa2TskPHFL+vlC5KhPv1gxg8sBQ9QW8j792nlo JKMtlQ2dnH1lo0VirNg6+ct8wWv7bsKNv5FuAA/9Y4mFphaPiFA6LZ2N+ohuwJ0SmN8r hABQ== X-Gm-Message-State: ANoB5pnTP/nXdBDL8sq99oSr4EV0tJeQXDW/gQwy5Q/IjxT7wzsepHXu 1LvC1zP6hFpdcLXmgHLDpvAWsA== X-Google-Smtp-Source: AA0mqf6+2/Kf1TS6UmIUGlAGSdFVvvwScfE4w+pqp9KJrFRimpQq2T3rPLgyXgCr4sJ2ukjHhyK7hw== X-Received: by 2002:a05:6830:1657:b0:66c:7856:3f72 with SMTP id h23-20020a056830165700b0066c78563f72mr4607019otr.136.1668344924170; Sun, 13 Nov 2022 05:08:44 -0800 (PST) Received: from fedora (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id h24-20020a9d6f98000000b00661b46cc26bsm3038805otq.9.2022.11.13.05.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Nov 2022 05:08:43 -0800 (PST) Date: Sun, 13 Nov 2022 08:08:40 -0500 From: William Breathitt Gray To: Andy Shevchenko Cc: linus.walleij@linaro.org, brgl@bgdev.pl, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, michael@walle.cc, broonie@kernel.org Subject: Re: [PATCH v2 2/4] regmap-irq: Add handle_mask_sync() callback Message-ID: References: <53e9e89cc9d7e9c20cbdfc13b360dcb43d07f832.1668129763.git.william.gray@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DjtPv7CPbqyv+G/s" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --DjtPv7CPbqyv+G/s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 13, 2022 at 02:42:49PM +0200, Andy Shevchenko wrote: > On Thu, Nov 10, 2022 at 08:55:51PM -0500, William Breathitt Gray wrote: > > Provide a public callback handle_mask_sync() that drivers can use when > > they have more complex IRQ masking logic. The default implementation is > > regmap_irq_handle_mask_sync(), used if the chip doesn't provide its own > > callback. >=20 > ... >=20 > > + * @handle_mask_sync: Callback used to handle IRQ mask syncs. The inde= x will be > > + * in the range [0, num_regs[ >=20 > Not sure if it's a typo ([ vs. ]), but if you want to say "not including = the > last", use mathematical notation, i.e. "[0, num_regs)". I was following the convention used in the @get_irq_reg description, but I agree that mathematical notation would be much clearer. William Breathitt Gray --DjtPv7CPbqyv+G/s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCY3DsWAAKCRC1SFbKvhIj K4pEAP4rJRoPAf6w7qKx+kurONAPY+V/0kAEK9c54tLiSI0OVwD7B1Aa7Py2Mn4V L7q5JQ0WfEulvWDyG9ctH9E81MOV0AM= =liqQ -----END PGP SIGNATURE----- --DjtPv7CPbqyv+G/s--