* [PATCH] dmaengine: idxd: Fix crc_val field for completion record
@ 2022-11-11 1:27 Fenghua Yu
2022-11-11 15:09 ` Dave Jiang
2022-11-13 22:28 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Fenghua Yu @ 2022-11-11 1:27 UTC (permalink / raw)
To: Vinod Koul, Dave Jiang; +Cc: linux-kernel, dmaengine, Fenghua Yu, Nirav N Shah
The crc_val in the completion record should be 64 bits and not 32 bits.
Fixes: 4ac823e9cd85 ("dmaengine: idxd: fix delta_rec and crc size field for completion record")
Reported-by: Nirav N Shah <nirav.n.shah@intel.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
---
include/uapi/linux/idxd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/idxd.h b/include/uapi/linux/idxd.h
index 61ee43823622..09947ae61663 100644
--- a/include/uapi/linux/idxd.h
+++ b/include/uapi/linux/idxd.h
@@ -329,7 +329,7 @@ struct dsa_completion_record {
};
uint32_t delta_rec_size;
- uint32_t crc_val;
+ uint64_t crc_val;
/* DIF check & strip */
struct {
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: idxd: Fix crc_val field for completion record
2022-11-11 1:27 [PATCH] dmaengine: idxd: Fix crc_val field for completion record Fenghua Yu
@ 2022-11-11 15:09 ` Dave Jiang
2022-11-13 22:28 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2022-11-11 15:09 UTC (permalink / raw)
To: Fenghua Yu, Vinod Koul; +Cc: linux-kernel, dmaengine, Nirav N Shah
On 11/10/2022 5:27 PM, Fenghua Yu wrote:
> The crc_val in the completion record should be 64 bits and not 32 bits.
>
> Fixes: 4ac823e9cd85 ("dmaengine: idxd: fix delta_rec and crc size field for completion record")
>
> Reported-by: Nirav N Shah <nirav.n.shah@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> include/uapi/linux/idxd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/idxd.h b/include/uapi/linux/idxd.h
> index 61ee43823622..09947ae61663 100644
> --- a/include/uapi/linux/idxd.h
> +++ b/include/uapi/linux/idxd.h
> @@ -329,7 +329,7 @@ struct dsa_completion_record {
> };
>
> uint32_t delta_rec_size;
> - uint32_t crc_val;
> + uint64_t crc_val;
>
> /* DIF check & strip */
> struct {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: idxd: Fix crc_val field for completion record
2022-11-11 1:27 [PATCH] dmaengine: idxd: Fix crc_val field for completion record Fenghua Yu
2022-11-11 15:09 ` Dave Jiang
@ 2022-11-13 22:28 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-11-13 22:28 UTC (permalink / raw)
To: Fenghua Yu; +Cc: Dave Jiang, linux-kernel, dmaengine, Nirav N Shah
On 10-11-22, 17:27, Fenghua Yu wrote:
> The crc_val in the completion record should be 64 bits and not 32 bits.
>
> Fixes: 4ac823e9cd85 ("dmaengine: idxd: fix delta_rec and crc size field for completion record")
>
Please no empty line after the fixes tag!
Applied after removing the empty line, thanks
> Reported-by: Nirav N Shah <nirav.n.shah@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> ---
> include/uapi/linux/idxd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/idxd.h b/include/uapi/linux/idxd.h
> index 61ee43823622..09947ae61663 100644
> --- a/include/uapi/linux/idxd.h
> +++ b/include/uapi/linux/idxd.h
> @@ -329,7 +329,7 @@ struct dsa_completion_record {
> };
>
> uint32_t delta_rec_size;
> - uint32_t crc_val;
> + uint64_t crc_val;
>
> /* DIF check & strip */
> struct {
> --
> 2.32.0
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-13 22:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-11 1:27 [PATCH] dmaengine: idxd: Fix crc_val field for completion record Fenghua Yu
2022-11-11 15:09 ` Dave Jiang
2022-11-13 22:28 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox