* [PATCH] staging: media: omap4iss: correct cacheflush import
@ 2022-11-13 0:33 Ian Cowan
2022-11-14 14:06 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Ian Cowan @ 2022-11-13 0:33 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media,
linux-staging, linux-kernel, Ian Cowan
Correct the import for cacheflush from the asm directory to the linux
directory.
Signed-off-by: Ian Cowan <ian@linux.cowan.aero>
---
drivers/staging/media/omap4iss/iss_video.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c
index 842509dcfedf..9f08dd976a24 100644
--- a/drivers/staging/media/omap4iss/iss_video.c
+++ b/drivers/staging/media/omap4iss/iss_video.c
@@ -7,6 +7,7 @@
* Author: Sergio Aguirre <sergio.a.aguirre@gmail.com>
*/
+#include <linux/cacheflush.h>
#include <linux/clk.h>
#include <linux/mm.h>
#include <linux/pagemap.h>
@@ -19,8 +20,6 @@
#include <media/v4l2-ioctl.h>
#include <media/v4l2-mc.h>
-#include <asm/cacheflush.h>
-
#include "iss_video.h"
#include "iss.h"
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: media: omap4iss: correct cacheflush import
2022-11-13 0:33 [PATCH] staging: media: omap4iss: correct cacheflush import Ian Cowan
@ 2022-11-14 14:06 ` Laurent Pinchart
2022-11-14 16:06 ` Ian Cowan
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2022-11-14 14:06 UTC (permalink / raw)
To: Ian Cowan
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media,
linux-staging, linux-kernel
Hi Ian,
Thank you for the patch.
On Sat, Nov 12, 2022 at 07:33:47PM -0500, Ian Cowan wrote:
> Correct the import for cacheflush from the asm directory to the linux
> directory.
Unless I'm mistaken, it looks like the header is actually not needed at
all.
> Signed-off-by: Ian Cowan <ian@linux.cowan.aero>
> ---
> drivers/staging/media/omap4iss/iss_video.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c
> index 842509dcfedf..9f08dd976a24 100644
> --- a/drivers/staging/media/omap4iss/iss_video.c
> +++ b/drivers/staging/media/omap4iss/iss_video.c
> @@ -7,6 +7,7 @@
> * Author: Sergio Aguirre <sergio.a.aguirre@gmail.com>
> */
>
> +#include <linux/cacheflush.h>
> #include <linux/clk.h>
> #include <linux/mm.h>
> #include <linux/pagemap.h>
> @@ -19,8 +20,6 @@
> #include <media/v4l2-ioctl.h>
> #include <media/v4l2-mc.h>
>
> -#include <asm/cacheflush.h>
> -
> #include "iss_video.h"
> #include "iss.h"
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: media: omap4iss: correct cacheflush import
2022-11-14 14:06 ` Laurent Pinchart
@ 2022-11-14 16:06 ` Ian Cowan
0 siblings, 0 replies; 3+ messages in thread
From: Ian Cowan @ 2022-11-14 16:06 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media,
linux-staging, linux-kernel
On Mon, Nov 14, 2022 at 04:06:50PM +0200, Laurent Pinchart wrote:
> Hi Ian,
>
> Thank you for the patch.
>
> On Sat, Nov 12, 2022 at 07:33:47PM -0500, Ian Cowan wrote:
> > Correct the import for cacheflush from the asm directory to the linux
> > directory.
>
> Unless I'm mistaken, it looks like the header is actually not needed at
> all.
Good catch - it's not needed at all. I'll submit a patch momentarily
that removes it completely.
ian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-14 16:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-13 0:33 [PATCH] staging: media: omap4iss: correct cacheflush import Ian Cowan
2022-11-14 14:06 ` Laurent Pinchart
2022-11-14 16:06 ` Ian Cowan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox