From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93227C433FE for ; Mon, 14 Nov 2022 14:54:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237011AbiKNOyh (ORCPT ); Mon, 14 Nov 2022 09:54:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236785AbiKNOyf (ORCPT ); Mon, 14 Nov 2022 09:54:35 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BCFA2669 for ; Mon, 14 Nov 2022 06:54:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 177A9611CE for ; Mon, 14 Nov 2022 14:54:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA0E2C433D6; Mon, 14 Nov 2022 14:54:31 +0000 (UTC) Date: Mon, 14 Nov 2022 14:54:28 +0000 From: Catalin Marinas To: Will Deacon Cc: Manivannan Sadhasivam , Amit Pundir , Robin Murphy , Bjorn Andersson , Sibi Sankar , Linus Torvalds , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov Subject: Re: [GIT PULL] arm64 updates for 6.1-rc1 Message-ID: References: <20221005144116.2256580-1-catalin.marinas@arm.com> <20221111173952.GB5393@thinkpad> <20221111191820.GC5393@thinkpad> <20221114140903.GF30263@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221114140903.GF30263@willie-the-truck> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 14, 2022 at 02:09:04PM +0000, Will Deacon wrote: > On Sat, Nov 12, 2022 at 12:48:20AM +0530, Manivannan Sadhasivam wrote: > > I digged a little further and found that the crash was due to the secure > > processor (XPU) violation. It happens because, CPU tried acccessing the memory > > after sharing it with the modem for firmware metadata validation. [...] > > Sibi tried fixing this problem earlier by using a hack in the remoteproc driver > > [1], but I guess that got negated due to c44094eee32f? > > Performing a clean rather than a clean+invalidate when the buffer is > allocated (which is what is achieved by c44094eee32f) shouldn't affect > this afaict. I agree. The DMA_ATTR_NO_KERNEL_MAPPING used in the qcom_q6v5_mss fix only ensures that there is no non-cacheable DMA mapping but we still have the kernel linear map in place that may be accessed speculatively by the CPU at any point. I can't tell why the clean+inval makes any difference but I suspect it's a matter of time before you'd hit similar conditions again (maybe not at boot). -- Catalin