From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E279C433FE for ; Mon, 14 Nov 2022 21:47:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237794AbiKNVrN (ORCPT ); Mon, 14 Nov 2022 16:47:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236128AbiKNVrL (ORCPT ); Mon, 14 Nov 2022 16:47:11 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4B7019C2A for ; Mon, 14 Nov 2022 13:47:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zR+/p7R1t4TzeOU8mz6hY5ameEwAhb4NtsNQ0xjhUD8=; b=Mt3AqQMklztbdZDjXkrNqtPBk9 SDLSAmnRuP3roc/lB9QR3Z17g8ZB7hUmskBGsjsKN9jGKj5lhBajd+dQa9cd/2xVhjRp+FfSo+tqA PN6nqi8yir6yZpdZLeB3K5KSsXDnDmDAGkK6MLad1T/AGUas3qx9h+3NzTQXtIzOyv5EI2qxeMPHS G2YRkENYidG6cdVj4jn9b5s27KItikGHK8/codTaF4LSOUVtLG8a5ITD7zQs212P1jS177dpSNY+U 6TXR6uG1GHpAYoWHXVB3FHOOW9kvL29Wz6AmuUxwxDFAufrG98+sCK8Wt66NoY3Gcnkr/L9SpCnwr TyvLK+1Q==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouhI9-00Fo7J-44; Mon, 14 Nov 2022 21:46:57 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 9EE67300422; Mon, 14 Nov 2022 22:46:49 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8BA352C777C44; Mon, 14 Nov 2022 22:46:49 +0100 (CET) Date: Mon, 14 Nov 2022 22:46:49 +0100 From: Peter Zijlstra To: Sean Christopherson Cc: Andrey Ryabinin , Dave Hansen , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, syzbot+ffb4f000dc2872c93f62@syzkaller.appspotmail.com, syzbot+8cdd16fd5a6c0565e227@syzkaller.appspotmail.com Subject: Re: [PATCH v2 5/5] x86/kasan: Populate shadow for shared chunk of the CPU entry area Message-ID: References: <20221110203504.1985010-1-seanjc@google.com> <20221110203504.1985010-6-seanjc@google.com> <3b7a841d-bbbd-6018-556f-d2414a5f02b2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 14, 2022 at 05:53:43PM +0000, Sean Christopherson wrote: > Wrong one, that's the existing mapping. To get back to v1: > > diff --git a/arch/x86/mm/kasan_init_64.c b/arch/x86/mm/kasan_init_64.c > index af82046348a0..0302491d799d 100644 > --- a/arch/x86/mm/kasan_init_64.c > +++ b/arch/x86/mm/kasan_init_64.c > @@ -416,8 +416,8 @@ void __init kasan_init(void) > * area is randomly placed somewhere in the 512GiB range and mapping > * the entire 512GiB range is prohibitively expensive. > */ > - kasan_populate_early_shadow((void *)shadow_cea_begin, > - (void *)shadow_cea_per_cpu_begin); > + kasan_populate_shadow(shadow_cea_begin, > + shadow_cea_per_cpu_begin, 0); > > kasan_populate_early_shadow((void *)shadow_cea_end, > kasan_mem_to_shadow((void *)__START_KERNEL_map)); OK. It now looks like so: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?h=x86/mm&id=14ca169feec3cb442ef4d322f8f65ba360f42784 If the robots don't hate on it because I fat fingered it or seomthing stupid, I'll go push it out tomorrow.