Re: [PATCH v2 01/14] platform/x86/intel/ifs: Remove unused selection

Hans de Goede
2022-11-10T21:05:01Z

Hi,

On 11/7/22 23:53, Jithu Joseph wrote:
> CONFIG_INTEL_IFS_DEVICE is not used anywhere. The selection in
> Kconfig is therefore pointless. Delete it.
>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

> ---
> drivers/platform/x86/intel/ifs/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/ifs/Kconfig b/drivers/platform/x86/intel/ifs/Kconfig
> index c341a27cc1a3..89152d46deee 100644
> --- a/drivers/platform/x86/intel/ifs/Kconfig
> +++ b/drivers/platform/x86/intel/ifs/Kconfig
> @@ -4,7 +4,6 @@ config INTEL_IFS
> # Discussion on the list has shown that the sysfs API needs a bit
> # more work, mark this as broken for now
> depends on BROKEN
> - select INTEL_IFS_DEVICE
> help
> Enable support for the In Field Scan capability in select
> CPUs. The capability allows for running low level tests via