Re: [PATCH v2 12/14] platform/x86/intel/ifs: Add current_batch sysfs entry

Joseph, Jithu
2022-11-13T17:55:21Z

On 11/13/2022 8:58 AM, Borislav Petkov wrote:
> On Sun, Nov 13, 2022 at 08:41:47AM -0800, Joseph, Jithu wrote:
>> Do you think it is better to restrict filename input to confirm
>> to ff-mm-ss-xy.<test> format rather than accepting any string and
>> treating it as a file-name and trying to load it, if it is present ?
>
> Yap, that way you pre-filter filenames. Yeah, the header checks *must*
> absolutely happen too but it would be a simple first test.
>
> Also, you can check for:
>
> ff-mm-ss-X.<test>
>
> where X is a [0-9]+ of arbitrary length and this way won't have the
> artificial 256 limit you have now.
>

Thanks for clarifying

>> (Given that, before loading, We do intel_find_matching_signature(),
>> which validates if the signature/pf entries in header confirms to the
>> machine we are on before loading)
>>
>> We did accepting file-name as input before [1] (except for validating
>> if the filename confirms to ff-mm-ss format)
>
> Yeah, except now you want to do multiple sets of scan files.

The earlier change (which modified reload sysfs file from accepting a file-name instead of 1) was for
allowing multiple test files (i.e no different from what we are doing now)

Then we were told not to specify a filename via sysfs file (apologies for being repetitive)

Jithu

[1] https://lore.kernel.org/lkml/20220710160011.995800-1-jithu.joseph@intel.com/