Re: [PATCH v2 10/14] platform/x86/intel/ifs: Add metadata validation

Sohil Mehta
2022-11-09T23:15:49Z

Jithu, I replied to the prior version of the series by mistake.
Duplicating that comment over here.

On 11/7/2022 2:53 PM, Jithu Joseph wrote:
> The data portion of IFS test image file contains a metadata
> region containing possibly multiple metadata structures in
> addition to test data and hashes.
>
> Introduce the layout of this meta_data structure and validate
> the sanity of certain fields of the new image before loading.
>
> Tweak references to IFS test image chunks to reflect the updated
> layout of the test image.
>

Can you provide some more information on the updated layout of the
metadata structure?

Some parts of validate_ifs_metadata() like the ifs_test_image_ptr
calculation would be easier to follow with that.