From: Brian Masney <bmasney@redhat.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] gpiolib: of: Use correct fwnode for DT-probed chips
Date: Mon, 14 Nov 2022 16:15:25 -0500 [thread overview]
Message-ID: <Y3Kv7XoBytwwy9pC@x1> (raw)
In-Reply-To: <20221111113732.461881-1-thierry.reding@gmail.com>
On Fri, Nov 11, 2022 at 12:37:32PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The OF node store in chip->fwnode is used to explicitly override the FW
> node for a GPIO chip. For chips that use the default FW node (i.e. that
> of their parent device), this will be NULL and cause the chip not to be
> fully registered.
>
> Instead, use the GPIO device's FW node, which is set to either the node
> of the parent device or the explicit override in chip->fwnode.
>
> Fixes: 8afe82550240 ("gpiolib: of: Prepare of_gpiochip_add() / of_gpiochip_remove() for fwnode")
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Brian Masney <bmasney@redhat.com>
Tested-by: Brian Masney <bmasney@redhat.com>
I separately sent a similar type of patch to fix the same issue today:
https://lore.kernel.org/linux-arm-msm/20221114202943.2389489-1-bmasney@redhat.com/T/#u
I'm still not sure what caused this breakage in linux-next.
Brian
next prev parent reply other threads:[~2022-11-14 21:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 11:37 [PATCH] gpiolib: of: Use correct fwnode for DT-probed chips Thierry Reding
2022-11-11 11:45 ` Andy Shevchenko
2022-11-11 15:12 ` Thierry Reding
2022-11-11 14:21 ` Linus Walleij
2022-11-12 12:59 ` Robert Marko
2022-11-14 21:12 ` Andrew Halaney
2022-11-14 21:15 ` Brian Masney [this message]
2022-11-15 11:18 ` Marijn Suijten
2022-11-15 11:41 ` Brian Masney
2022-11-16 10:26 ` Thierry Reding
2022-11-16 10:38 ` Andy Shevchenko
2022-11-16 14:05 ` Thierry Reding
2022-11-16 16:06 ` Marijn Suijten
2022-11-15 11:13 ` Geert Uytterhoeven
2022-11-15 14:38 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3Kv7XoBytwwy9pC@x1 \
--to=bmasney@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox