* [PATCH] irqchip/wpcm450: fix memory leak in ap_init_qci_info()
@ 2022-11-14 11:08 Wei Yongjun
2022-11-15 8:36 ` Jonathan Neuschäfer
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2022-11-14 11:08 UTC (permalink / raw)
To: Jonathan Neuschäfer, Thomas Gleixner, Marc Zyngier
Cc: Wei Yongjun, openbmc, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
If of_iomap() failed, 'aic' should be freed before return. Otherwise
there is a memory leak.
Fixes: fead4dd49663 ("irqchip: Add driver for WPCM450 interrupt controller")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/irqchip/irq-wpcm450-aic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-wpcm450-aic.c b/drivers/irqchip/irq-wpcm450-aic.c
index 0dcbeb1a05a1..91df62a64cd9 100644
--- a/drivers/irqchip/irq-wpcm450-aic.c
+++ b/drivers/irqchip/irq-wpcm450-aic.c
@@ -146,6 +146,7 @@ static int __init wpcm450_aic_of_init(struct device_node *node,
aic->regs = of_iomap(node, 0);
if (!aic->regs) {
pr_err("Failed to map WPCM450 AIC registers\n");
+ kfree(aic);
return -ENOMEM;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] irqchip/wpcm450: fix memory leak in ap_init_qci_info()
2022-11-14 11:08 [PATCH] irqchip/wpcm450: fix memory leak in ap_init_qci_info() Wei Yongjun
@ 2022-11-15 8:36 ` Jonathan Neuschäfer
2022-11-15 9:10 ` Wei Yongjun
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Neuschäfer @ 2022-11-15 8:36 UTC (permalink / raw)
To: Wei Yongjun
Cc: Jonathan Neuschäfer, Thomas Gleixner, Marc Zyngier,
Wei Yongjun, openbmc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]
Hi,
the function name is wrong in the in the subject line. Other than that,
the patch looks good.
Thanks,
Jonathan
On Mon, Nov 14, 2022 at 11:08:54AM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> If of_iomap() failed, 'aic' should be freed before return. Otherwise
> there is a memory leak.
>
> Fixes: fead4dd49663 ("irqchip: Add driver for WPCM450 interrupt controller")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/irqchip/irq-wpcm450-aic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/irq-wpcm450-aic.c b/drivers/irqchip/irq-wpcm450-aic.c
> index 0dcbeb1a05a1..91df62a64cd9 100644
> --- a/drivers/irqchip/irq-wpcm450-aic.c
> +++ b/drivers/irqchip/irq-wpcm450-aic.c
> @@ -146,6 +146,7 @@ static int __init wpcm450_aic_of_init(struct device_node *node,
> aic->regs = of_iomap(node, 0);
> if (!aic->regs) {
> pr_err("Failed to map WPCM450 AIC registers\n");
> + kfree(aic);
> return -ENOMEM;
> }
>
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] irqchip/wpcm450: fix memory leak in ap_init_qci_info()
2022-11-15 8:36 ` Jonathan Neuschäfer
@ 2022-11-15 9:10 ` Wei Yongjun
0 siblings, 0 replies; 3+ messages in thread
From: Wei Yongjun @ 2022-11-15 9:10 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: Thomas Gleixner, Marc Zyngier, Wei Yongjun, openbmc, linux-kernel
On 2022/11/15 16:36, Jonathan Neuschäfer wrote:
> Hi,
>
> the function name is wrong in the in the subject line. Other than that,
> the patch looks good.
Thanks, will fix in next version.
Regards,
Wei Yongjun
>
> Thanks,
> Jonathan
>
>
> On Mon, Nov 14, 2022 at 11:08:54AM +0000, Wei Yongjun wrote:
>> From: Wei Yongjun <weiyongjun1@huawei.com>
>>
>> If of_iomap() failed, 'aic' should be freed before return. Otherwise
>> there is a memory leak.
>>
>> Fixes: fead4dd49663 ("irqchip: Add driver for WPCM450 interrupt controller")
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> ---
>> drivers/irqchip/irq-wpcm450-aic.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/irqchip/irq-wpcm450-aic.c b/drivers/irqchip/irq-wpcm450-aic.c
>> index 0dcbeb1a05a1..91df62a64cd9 100644
>> --- a/drivers/irqchip/irq-wpcm450-aic.c
>> +++ b/drivers/irqchip/irq-wpcm450-aic.c
>> @@ -146,6 +146,7 @@ static int __init wpcm450_aic_of_init(struct device_node *node,
>> aic->regs = of_iomap(node, 0);
>> if (!aic->regs) {
>> pr_err("Failed to map WPCM450 AIC registers\n");
>> + kfree(aic);
>> return -ENOMEM;
>> }
>>
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-15 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-14 11:08 [PATCH] irqchip/wpcm450: fix memory leak in ap_init_qci_info() Wei Yongjun
2022-11-15 8:36 ` Jonathan Neuschäfer
2022-11-15 9:10 ` Wei Yongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox