From: Leon Romanovsky <leon@kernel.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: rostedt@goodmis.org, linux-nfs@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] trace: Relocate event helper files
Date: Tue, 15 Nov 2022 10:55:06 +0200 [thread overview]
Message-ID: <Y3NT6sCGhtf16FaO@unreal> (raw)
In-Reply-To: <166843895843.170837.8663873976042560070.stgit@klimt.1015granger.net>
On Mon, Nov 14, 2022 at 10:16:12AM -0500, Chuck Lever wrote:
> Steven Rostedt says:
> > The include/trace/events/ directory should only hold files that
> > are to create events, not headers that hold helper functions.
> >
> > Can you please move them out of include/trace/events/ as that
> > directory is "special" in the creation of events.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> drivers/infiniband/core/cm_trace.h | 2
> drivers/infiniband/core/cma_trace.h | 2
> fs/nfs/nfs4trace.h | 6 -
> fs/nfs/nfstrace.h | 6 -
> include/trace/events/fs.h | 122 -----------
> include/trace/events/nfs.h | 375 -----------------------------------
> include/trace/events/rdma.h | 168 ----------------
> include/trace/events/rpcgss.h | 2
> include/trace/events/rpcrdma.h | 4
> include/trace/events/sunrpc.h | 2
> include/trace/events/sunrpc_base.h | 18 --
> include/trace/misc/fs.h | 122 +++++++++++
> include/trace/misc/nfs.h | 375 +++++++++++++++++++++++++++++++++++
> include/trace/misc/rdma.h | 168 ++++++++++++++++
> include/trace/misc/sunrpc.h | 18 ++
> 15 files changed, 695 insertions(+), 695 deletions(-)
> delete mode 100644 include/trace/events/fs.h
> delete mode 100644 include/trace/events/nfs.h
> delete mode 100644 include/trace/events/rdma.h
> delete mode 100644 include/trace/events/sunrpc_base.h
> create mode 100644 include/trace/misc/fs.h
> create mode 100644 include/trace/misc/nfs.h
> create mode 100644 include/trace/misc/rdma.h
> create mode 100644 include/trace/misc/sunrpc.h
>
> Note: with an Acked-by from both the NFS client and RDMA core
> maintainers I can take this through the nfsd for-next tree, unless
> someone has another suggestion.
Please update MAINTAINERS file too.
diff --git a/MAINTAINERS b/MAINTAINERS
index 4db8e4e02c05..86e57325eb6e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10054,6 +10054,7 @@ F: drivers/infiniband/
F: include/rdma/
F: include/trace/events/ib_mad.h
F: include/trace/events/ib_umad.h
+F: include/trace/misc/rdma.h
F: include/uapi/linux/if_infiniband.h
F: include/uapi/rdma/
F: samples/bpf/ibumad_kern.c
Thanks,
Acked-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2022-11-15 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 15:16 [PATCH v2] trace: Relocate event helper files Chuck Lever
2022-11-15 8:55 ` Leon Romanovsky [this message]
2022-11-15 14:23 ` Chuck Lever III
2022-11-15 14:26 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3NT6sCGhtf16FaO@unreal \
--to=leon@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox