From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH v2 1/2] pwm: core: Refactor pwmchip_add() to avoid extra checks
Date: Wed, 16 Nov 2022 10:22:56 +0200 [thread overview]
Message-ID: <Y3Sd4BYkkjLUv5ka@smile.fi.intel.com> (raw)
In-Reply-To: <20221115202412.77d52oafpplzu5bw@pengutronix.de>
On Tue, Nov 15, 2022 at 09:24:12PM +0100, Uwe Kleine-König wrote:
> On Mon, Nov 14, 2022 at 07:00:04PM +0200, Andy Shevchenko wrote:
> > When we already know that everything is fine there is no need
> > to use ret variable. Refactor code accordingly.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> The patch is correct (i.e. doesn't change the semantic of the function).
>
> But I think there is some more potential to clean up than it used here.
> I will send out a series that I like better than this patch.
Fine, can you attach the second patch of this series to yours v2, please?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-16 8:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 17:00 [PATCH v2 1/2] pwm: core: Refactor pwmchip_add() to avoid extra checks Andy Shevchenko
2022-11-14 17:00 ` [PATCH v2 2/2] pwm: core: Remove S_IFREG from debugfs_create_file() Andy Shevchenko
2022-11-15 20:24 ` [PATCH v2 1/2] pwm: core: Refactor pwmchip_add() to avoid extra checks Uwe Kleine-König
2022-11-16 8:22 ` Andy Shevchenko [this message]
2022-11-17 13:54 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3Sd4BYkkjLUv5ka@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox