Re: [PATCH] irqchip/imx: Do not unconditionally enable GENERIC_MSI_IRQ

Thomas Gleixner
2023-01-17T09:27:45Z

On Fri, Jan 13 2023 at 13:17, Ingo Molnar wrote:
> config IMX_MU_MSI
> tristate "i.MX MU used as MSI controller"
> depends on OF && HAS_IOMEM
> depends on ARCH_MXC || COMPILE_TEST
> default m if ARCH_MXC
> select IRQ_DOMAIN
> select IRQ_DOMAIN_HIERARCHY
> select GENERIC_MSI_IRQ
> help
>
> But that's not unconditionally valid - for example on x86 UP kernel builds
> that have the local APIC disabled there's no MSI functionality - resulting
> in build failures like:
>
> ./include/linux/gpio/driver.h:32:33: error: field ‘msiinfo’ has incomplete type
> kernel/irq/msi.c:739:19: error: invalid use of incomplete typedef ‘msi_alloc_info_t’ {aka ‘struct irq_alloc_info’}

What prevents us from either

- exposing msi_alloc_info_t unconditionally (it should not matter)

or

- killing that 32bit UP && APIC=n combo (which removes quite some
ifdef cruft)

Thanks,

tglx