Re: [PATCH 10/18] mfd: rohm-bd71828: Replace irqchip mask_invert with unmask_base

Matti Vaittinen
2022-11-14T06:26:29Z

On 11/12/22 17:18, Aidan MacDonald wrote:
> Remove use of the deprecated mask_invert flag. Inverted mask
> registers (where a '1' bit enables an IRQ) can be described more
> directly as an unmask register.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>

> ---
> drivers/mfd/rohm-bd71828.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mfd/rohm-bd71828.c b/drivers/mfd/rohm-bd71828.c
> index 714d9fcbf07b..3c5c6c393650 100644
> --- a/drivers/mfd/rohm-bd71828.c
> +++ b/drivers/mfd/rohm-bd71828.c
> @@ -413,9 +413,8 @@ static struct regmap_irq_chip bd71828_irq_chip = {
> .irqs = &bd71828_irqs[0],
> .num_irqs = ARRAY_SIZE(bd71828_irqs),
> .status_base = BD71828_REG_INT_BUCK,
> - .mask_base = BD71828_REG_INT_MASK_BUCK,
> + .unmask_base = BD71828_REG_INT_MASK_BUCK,
> .ack_base = BD71828_REG_INT_BUCK,
> - .mask_invert = true,
> .init_ack_masked = true,
> .num_regs = 12,
> .num_main_regs = 1,
> @@ -430,9 +429,8 @@ static struct regmap_irq_chip bd71815_irq_chip = {
> .irqs = &bd71815_irqs[0],
> .num_irqs = ARRAY_SIZE(bd71815_irqs),
> .status_base = BD71815_REG_INT_STAT_01,
> - .mask_base = BD71815_REG_INT_EN_01,
> + .unmask_base = BD71815_REG_INT_EN_01,
> .ack_base = BD71815_REG_INT_STAT_01,
> - .mask_invert = true,
> .init_ack_masked = true,
> .num_regs = 12,
> .num_main_regs = 1,

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~