Re: [PATCH 05/18] mfd: max14577: Replace irqchip mask_invert with unmask_base

Lee Jones
2022-11-14T14:03:33Z

On Mon, 14 Nov 2022, Aidan MacDonald wrote:

>
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
>
> > On 12/11/2022 16:18, Aidan MacDonald wrote:
> >> Remove use of the deprecated mask_invert flag. Inverted mask
> >> registers (where a '1' bit enables an IRQ) can be described more
> >> directly as an unmask register.
> >>
> >> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> >> ---
> >> drivers/mfd/max14577.c | 7 ++-----
> >> 1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > Mention this is a resend or provide a changelog for v2.
>
> Most of these patches are resends, but they're so trivial it seems
> pointless to mention that fact. There are no changes from v1.

How are people supposed to know the difference between "no change"
and "there have been lots of changes, but I forgot to add a
change-log"? :)

Nothing wrong with:

v1 -> v2:
No code changes

> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > Best regards,
> > Krzysztof

--
Lee Jones [李琼斯]