From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73D76C43217 for ; Wed, 16 Nov 2022 18:01:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234653AbiKPSBB (ORCPT ); Wed, 16 Nov 2022 13:01:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234897AbiKPSAk (ORCPT ); Wed, 16 Nov 2022 13:00:40 -0500 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFB1C61BBD for ; Wed, 16 Nov 2022 10:00:39 -0800 (PST) Received: by mail-pf1-x42d.google.com with SMTP id k15so18220059pfg.2 for ; Wed, 16 Nov 2022 10:00:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nZ4ednm6peE6gbmoqpZClMscPku5YJZ1wCBTU6Ikzio=; b=WTdulvpvTtll9lziEFDV50ImfoMCVIGbLflaO//uDyLKMCD+NXKNZ28jPPeof7JS/L b6QUxEh0GHceWpIqWY/8VM6LGkqwASDX7+axp36Vvd+kha4FZDgmLT6LfN1ZeejIQEp6 lCThel7lsl3F5Eq0LHZTUlpaSkg1uZrR9fLNnqts3WyUvwFb3tpFV2nuAc+CoQduJbrd Ft3i+l4mEMchOWLw/4hyupeES7aGDgWTiTpKqKoI9l7c1wqGRLnU7okFktuqirDsgXpo m18yTtuzDY6o/awieSAPFYsaixsAeqZCiqqz5EkWeRgsScVh25AUPKUuaixjw0+1sOoK MChA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nZ4ednm6peE6gbmoqpZClMscPku5YJZ1wCBTU6Ikzio=; b=aocklHps8dndDpNQWH5xFG89EUWBZifRjZni6XVHokcgY/tpb4GAwtU1orRB0Qs/vi zKG+q5hVCm1EM3ooVGs0NuyGiMY0F4helkZM/JwEITBSsAqgN4hBY96Ph6D7giEzyY1j +3YZ4KxeCiBid1X07RyOYpeddll3R0MpiAH3tJlKBliXGGGqGqohGX27EP4hijkW5iaC J2NOpIzGnbOq49Rzee0hqgoddBLlnC/UBXdEoHBkL9nkUD+bdev7yXPFkrPMMqSBsVNY LfaZsiYApoATuTANx3FqdH2xjmZjfN0jrCJ3qVXM8qI7w1vAraoj7aoqGEATfir3cXW4 NDIQ== X-Gm-Message-State: ANoB5pnnAE3pFOtNDNtduy8KL0u3Q9WVy92rScbllSfvieuR89VL2iyK tuCfwdMUpTBPvN/HQuTXSvO0Dw== X-Google-Smtp-Source: AA0mqf6IW9b5cDWoM0bmrA1MVnJz4YY7y6phqjUqJJfwjTXzvzEY3JYpg1jW4Ijnid60/ii3HFAzdw== X-Received: by 2002:a63:135f:0:b0:476:a62c:b2a6 with SMTP id 31-20020a63135f000000b00476a62cb2a6mr9582900pgt.588.1668621639185; Wed, 16 Nov 2022 10:00:39 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id c17-20020a170902d49100b0017a032d7ae4sm12685441plg.104.2022.11.16.10.00.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 10:00:38 -0800 (PST) Date: Wed, 16 Nov 2022 18:00:35 +0000 From: Sean Christopherson To: Vishal Annapurve Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, pbonzini@redhat.com, shuah@kernel.org, bgardon@google.com, oupton@google.com, peterx@redhat.com, vkuznets@redhat.com, dmatlack@google.com, pgonda@google.com, andrew.jones@linux.dev Subject: Re: [V4 PATCH 0/3] Minor improvements to the selftest setup logic Message-ID: References: <20221115213845.3348210-1-vannapurve@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221115213845.3348210-1-vannapurve@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 15, 2022, Vishal Annapurve wrote: > This series is posted in context of the discussion at: > https://lore.kernel.org/lkml/Ywa9T+jKUpaHLu%2Fl@google.com/ > > Major changes: > 1) Move common startup logic to a single function in kvm_util.c > 2) Introduce following APIs: > kvm_selftest_arch_init: to perform arch specific common startup. > kvm_arch_vm_post_create: to perform arch specific common setup > after VM creation. Looks good! A few uber nits, but nothing that can't be fixed up when applying.