From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wolfram Sang <wsa@kernel.org>, Yinbo Zhu <zhuyinbo@loongson.cn>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Jean Delvare <jdelvare@suse.de>,
William Zhang <william.zhang@broadcom.com>,
Conor Dooley <conor.dooley@microchip.com>,
Jan Dabros <jsd@semihalf.com>,
Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Tyrone Ting <kfting@nuvoton.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] i2c: loongson: add bus driver for the loongson i2c controller
Date: Thu, 17 Nov 2022 10:47:10 +0200 [thread overview]
Message-ID: <Y3X1Dppjg/yGgLSS@smile.fi.intel.com> (raw)
In-Reply-To: <Y3XyU70QJruJUsI0@ninjato>
On Thu, Nov 17, 2022 at 09:35:31AM +0100, Wolfram Sang wrote:
>
> > Can you split slave part as a separate change? It will help to review and
> > to understand the code better in the future by browsing the history.
>
> Thanks for all your reviewing help, Andy! Regarding this comment, I
> don't think a split is needed. The driver is small enough with ~500
> lines, so I think it can stay this way. It would be different if the
> driver was 1000+ lines, then I'd totally agree. I will have a look at
> this driver soon.
Depends on the ratio "Comments per LoC" by the certain reviewer.
My experience with the other drivers for this architecture / platform that they
all need much more work before accepting them. And to reduce burden split would
be good.
But then it's up to you (to me it's a burden for even these 500 LoCs,
that are full of room to improvement).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-17 8:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 7:59 [PATCH v1 1/2] i2c: loongson: add bus driver for the loongson i2c controller Yinbo Zhu
2022-11-17 7:59 ` [PATCH v1 2/2] dt-bindings: i2c: add loongson i2c Yinbo Zhu
2022-11-20 17:23 ` Rob Herring
2022-11-17 8:28 ` [PATCH v1 1/2] i2c: loongson: add bus driver for the loongson i2c controller Andy Shevchenko
2022-11-17 8:35 ` Wolfram Sang
2022-11-17 8:47 ` Andy Shevchenko [this message]
2022-11-17 8:44 ` Andy Shevchenko
2022-11-28 13:13 ` Yinbo Zhu
2022-11-28 13:25 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3X1Dppjg/yGgLSS@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=jsd@semihalf.com \
--cc=kfting@nuvoton.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=phil.edworthy@renesas.com \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tharunkumar.pasumarthi@microchip.com \
--cc=william.zhang@broadcom.com \
--cc=wsa@kernel.org \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox