From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Thierry Reding <thierry.reding@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-pwm@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v4 3/7] pwm: lpss: Include headers we are the direct user of
Date: Thu, 17 Nov 2022 11:03:42 +0200 [thread overview]
Message-ID: <Y3X47vdt8MpHNzcB@smile.fi.intel.com> (raw)
In-Reply-To: <20221117085027.f5qy5rsauo7vhvw2@pengutronix.de>
On Thu, Nov 17, 2022 at 09:50:27AM +0100, Uwe Kleine-König wrote:
> On Mon, Nov 14, 2022 at 06:55:41PM +0200, Andy Shevchenko wrote:
> > For the sake of integrity, include headers we are the direct
> > user of.
> >
> > Replace the inclusion of device.h by a forward declaration
> > of struct device plus a (cheaper) of types.h as device.h is
> > an expensive include (measured in compiler effort).
> >
> > While at it, move the struct pwm_lpss_chip to be after
> > the struct pwm_lpss_boardinfo as the former uses pointer
> > to the latter.
>
> I stand by my feedback that this change is irrelevant in the end. If you
> drop it here, the patch gets a bit nicer.
OK, since you are insisting, I will modify this in v5.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-17 9:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 16:55 [PATCH v4 0/7] pinctrl: intel: Enable PWM optional feature Andy Shevchenko
2022-11-14 16:55 ` [PATCH v4 1/7] pwm: Add a stub for devm_pwmchip_add() Andy Shevchenko
2022-11-14 16:55 ` [PATCH v4 2/7] pwm: lpss: Rename MAX_PWMS --> LPSS_MAX_PWMS Andy Shevchenko
2022-11-14 16:55 ` [PATCH v4 3/7] pwm: lpss: Include headers we are the direct user of Andy Shevchenko
2022-11-17 8:50 ` Uwe Kleine-König
2022-11-17 9:03 ` Andy Shevchenko [this message]
2022-11-14 16:55 ` [PATCH v4 4/7] pwm: lpss: Allow other drivers to enable PWM LPSS Andy Shevchenko
2022-11-17 8:51 ` Uwe Kleine-König
2022-11-14 16:55 ` [PATCH v4 5/7] pwm: lpss: Rename pwm_lpss_probe() --> devm_pwm_lpss_probe() Andy Shevchenko
2022-11-17 8:52 ` Uwe Kleine-König
2022-11-14 16:55 ` [PATCH v4 6/7] pwm: lpss: Add devm_pwm_lpss_probe() stub Andy Shevchenko
2022-11-14 16:55 ` [PATCH v4 7/7] pinctrl: intel: Enumerate PWM device when community has a capability Andy Shevchenko
2022-11-17 9:06 ` Uwe Kleine-König
2022-11-17 10:37 ` Andy Shevchenko
2022-11-16 17:32 ` [PATCH v4 0/7] pinctrl: intel: Enable PWM optional feature Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3X47vdt8MpHNzcB@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox