From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 009A9C433FE for ; Thu, 17 Nov 2022 13:26:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239981AbiKQN0c (ORCPT ); Thu, 17 Nov 2022 08:26:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231463AbiKQN03 (ORCPT ); Thu, 17 Nov 2022 08:26:29 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53BEA5F85B; Thu, 17 Nov 2022 05:26:28 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0D0B1B82067; Thu, 17 Nov 2022 13:26:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8AE5C433D7; Thu, 17 Nov 2022 13:26:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668691585; bh=IfKmwHiX5GRvwIZolGOLav4sQrf4LjhgufrKC731FrE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Sl66rHmMCkfMfxk0dwcuJuE3jaRNgKbrJ4+2BEnnvPDjgvxmVF4Tx1lseKcO4BvfT 7MvHkKAmLa6nLnq1qdeFF4RWL4n8d5YFn7oc15/AkvCu+88VSyM8agWoHN+KzZrPl0 X26w2fP/8VYpVU+gyWtf19j+Obfiq4jv4I7duUZc8NMafJSx93r5GOoRQuhsj4hXjO nx6loRnRL68eRV2NZ5g5qh0OIjrFn+QH/1sFwrQSGzBmHqYImo0k2d5kvQtulGBF6w qaBIRwl09tc+NLBhf3kFxLPvYACrViIBjzOjuw7WEP5XPwVWlZLrZVLdeOgvpdFLEo buJ0sTt796TxQ== Date: Thu, 17 Nov 2022 13:26:21 +0000 From: Lee Jones To: Greg KH Cc: balbi@kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 1/1] usb: gadget: f_hid: Conduct proper refcounting on shared f_hidg pointer Message-ID: References: <20221117120813.1257583-1-lee@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Nov 2022, Greg KH wrote: > On Thu, Nov 17, 2022 at 12:08:13PM +0000, Lee Jones wrote: > > A reference to struct f_hidg is shared with this driver's associated > > character device handling component without provision for life-time > > handling. In some circumstances, this can lead to unwanted > > behaviour depending on the order in which things are torn down. > > > > Utilise, the reference counting functionality already provided by the > > implanted character device structure to ensure the struct f_hidg's > > memory is only freed once the character device handling has finished > > with it. > > > > Signed-off-by: Lee Jones > > --- > > drivers/usb/gadget/function/f_hid.c | 47 +++++++++++++++++++++++------ > > 1 file changed, 37 insertions(+), 10 deletions(-) > > Hi, > > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him > a patch that has triggered this response. He used to manually respond > to these common problems, but in order to save his sanity (he kept > writing the same thing over and over, yet to different people), I was > created. Hopefully you will not take offence and will fix the problem > in your patch and resubmit it so that it can be accepted into the Linux > kernel tree. > > You are receiving this message because of the following common error(s) > as indicated below: > > - This looks like a new version of a previously submitted patch, but you > did not list below the --- line any changes from the previous version. > Please read the section entitled "The canonical patch format" in the > kernel file, Documentation/SubmittingPatches for what needs to be done > here to properly describe this. > > If you wish to discuss this problem further, or you have questions about > how to resolve this issue, please feel free to respond to this email and > Greg will reply once he has dug out from the pending patches received > from other developers. > > thanks, > > greg k-h's patch email bot This is a completely new solution to the same problem. I'm treating this as a brand new submission. -- Lee Jones [李琼斯]