From: Dan Carpenter <error27@gmail.com>
To: Umang Jain <umang.jain@ideasonboard.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stefan Wahren <wahrenst@gmx.net>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
kieran.bingham@ideasonboard.com
Subject: Re: [PATCH 2/2] staging: vc04_services: mmal-common: Do not use bool in structures
Date: Thu, 17 Nov 2022 16:48:44 +0300 [thread overview]
Message-ID: <Y3Y7vCk3gwDH/TpK@kadam> (raw)
In-Reply-To: <20221117125953.88441-3-umang.jain@ideasonboard.com>
On Thu, Nov 17, 2022 at 06:29:53PM +0530, Umang Jain wrote:
> Do not use bool in structures, it already gets flagged by checkpatch:
>
> "Avoid using bool structure members because of possible alignment issues"
>
This checkpatch warning was removed almost 4 years ago.
regards,
dan carpenter
prev parent reply other threads:[~2022-11-17 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 12:59 [PATCH 0/2] vc04_services: vchiq-mmal: Drop bool usage Umang Jain
2022-11-17 12:59 ` [PATCH 1/2] staging: vc04_services: mmal-vchiq: Do not assign bool to u32 Umang Jain
2022-11-17 13:13 ` Greg Kroah-Hartman
2022-11-17 13:27 ` Umang Jain
2022-11-17 13:50 ` Dan Carpenter
2022-11-17 13:43 ` Dan Carpenter
2022-11-17 12:59 ` [PATCH 2/2] staging: vc04_services: mmal-common: Do not use bool in structures Umang Jain
2022-11-17 13:13 ` Greg Kroah-Hartman
2022-11-17 13:48 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3Y7vCk3gwDH/TpK@kadam \
--to=error27@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab+samsung@kernel.org \
--cc=umang.jain@ideasonboard.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox