Re: [PATCH 06/13] KVM: SVM: Add VNMI bit definition

Sean Christopherson
2022-11-17T16:43:08Z

On Thu, Nov 17, 2022, Borislav Petkov wrote:
> On Thu, Nov 17, 2022 at 04:32:35PM +0200, Maxim Levitsky wrote:
> > @@ -5029,6 +5031,10 @@ static __init int svm_hardware_setup(void)
> > svm_x86_ops.vcpu_get_apicv_inhibit_reasons = NULL;
> > }
> >
> > + vnmi = vnmi && boot_cpu_has(X86_FEATURE_AMD_VNMI);
>
> s/boot_cpu_has/cpu_feature_enabled/

Why? This is rarely run code, won't cpu_feature_enabled() unnecessarily require
patching?

And while we're on the topic... https://lore.kernel.org/all/Y22IzA9DN%2FxYWgWN@google.com