From: Daniel Golle <daniel@makrotopia.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 3/4] blkdev: add function to add named read-only partitions
Date: Thu, 17 Nov 2022 17:12:46 +0000 [thread overview]
Message-ID: <Y3Zrjsr3N76mFijj@makrotopia.org> (raw)
In-Reply-To: <Y3XNFXMaYFesFa+j@infradead.org>
On Wed, Nov 16, 2022 at 09:56:37PM -0800, Christoph Hellwig wrote:
> On Thu, Nov 17, 2022 at 12:44:40AM +0000, Daniel Golle wrote:
> > Add function bdev_add_partition_ro() which can be used by drivers to
> > register named read-only partitions on a disk device.
> > Unlike the existing bdev_add_partition() function, there is also no
> > check for overlapping partitions.
> > This new function is going to be used by the uImage.FIT parser.
>
> Err, no. No on has any business adding partitions to the block device
> except for the partition parser.
Well, there is a user-space ioctl for this as well[1], just that won't
set the partition to read-only and also doesn't allow naming it...
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/block/ioctl.c#n40
next prev parent reply other threads:[~2022-11-17 17:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 0:42 [RFC PATCH 0/4] block: uImage.FIT filesystem image mapper Daniel Golle
2022-11-17 0:42 ` [RFC PATCH 1/4] init: move block device helpers from init/do_mounts.c Daniel Golle
2022-11-17 5:55 ` Christoph Hellwig
2022-11-19 16:03 ` Daniel Golle
2022-11-22 12:37 ` Christoph Hellwig
2022-12-09 17:00 ` Daniel Golle
2022-12-12 9:03 ` Christoph Hellwig
2022-12-12 11:02 ` Daniel Golle
2022-12-13 6:48 ` Christoph Hellwig
2022-12-13 12:45 ` Daniel Golle
2022-12-14 16:43 ` Christoph Hellwig
2022-12-14 20:01 ` Daniel Golle
2022-12-15 8:09 ` Christoph Hellwig
2023-03-30 14:43 ` Daniel Golle
2022-11-17 0:43 ` [RFC PATCH 2/4] block: add new flag to add partitions read-only Daniel Golle
2022-11-17 0:44 ` [RFC PATCH 3/4] blkdev: add function to add named read-only partitions Daniel Golle
2022-11-17 5:56 ` Christoph Hellwig
2022-11-17 17:12 ` Daniel Golle [this message]
2022-11-17 0:45 ` [RFC PATCH 4/4] block: add uImage.FIT block partition driver Daniel Golle
2022-11-17 5:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3Zrjsr3N76mFijj@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox