public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Brent Pappas <bpappas@pappasbrent.com>
Cc: johan@kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: gdm724x: Replace macro GDM_TTY_READY with static inline function
Date: Thu, 17 Nov 2022 19:49:59 +0100	[thread overview]
Message-ID: <Y3aCV4rSrfrptA0q@kroah.com> (raw)
In-Reply-To: <20221116192412.22446-1-bpappas@pappasbrent.com>

On Wed, Nov 16, 2022 at 02:24:13PM -0500, Brent Pappas wrote:
> Replace the macro GDM_TTY_READY with a static inline function
> to follow the Linux kernel coding style.
> 
> Signed-off-by: Brent Pappas <bpappas@pappasbrent.com>
> ---
>  drivers/staging/gdm724x/gdm_tty.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index cc6d80554c98..93d50d42a367 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -21,7 +21,10 @@
>  
>  #define MUX_TX_MAX_SIZE 2048
>  
> -#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count)
> +static inline int gdm_tty_ready(struct gdm *gdm)

Why is this "int" and not "bool"?

thanks,

greg k-h

  reply	other threads:[~2022-11-17 18:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 19:24 [PATCH 1/1] staging: gdm724x: Replace macro GDM_TTY_READY with static inline function Brent Pappas
2022-11-17 18:49 ` Greg KH [this message]
2022-11-17 19:54   ` [PATCH 1/1 v2] " Brent Pappas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3aCV4rSrfrptA0q@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bpappas@pappasbrent.com \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox