From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42526C433FE for ; Fri, 18 Nov 2022 02:01:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240685AbiKRCBX (ORCPT ); Thu, 17 Nov 2022 21:01:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232004AbiKRCBO (ORCPT ); Thu, 17 Nov 2022 21:01:14 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EA85786CD for ; Thu, 17 Nov 2022 18:01:11 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2E9CEB82264 for ; Fri, 18 Nov 2022 02:01:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78411C433D7; Fri, 18 Nov 2022 02:01:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668736868; bh=NI+ThJ1IGK19Iit3qvb9g0K7eh5Yy44Q4BXLgtbQeKc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nbrDxSzQhO7W1h02c2ggEyLF+JxyQbFDT0W2ocUShnVz78k5LqU8MaD9ELJsvCHh0 lX8Pldh0AuhNDjKkDLwcD1D8GRmDhVGFwuXpc10BRwpEQXNc6nWMM7UmphgzcqYouu jKQt2GMPjFEeZ87lOYNIGV5Ldfx0uEUYfBCJ3VoNRZyzQevvbSKGRMBbgYTxyVDtBu hHsE86pRMGX8XBrcAiS8CK7qKUYRdv16NwIfAEmpnjEJZG/jKvoKCnkIQFAPswGwj9 4FSlbUn/vJo2hg/yBtsiMBz0G1NTL+GSPi5VF3UmgDgqvU8N3bCJre6WBqfNz7qp97 8uZGtdvFxHL8A== Date: Fri, 18 Nov 2022 10:01:05 +0800 From: Tzung-Bi Shih To: Gwendal Grignou Cc: dtor@chromium.org, jwerner@chromium.org, bleung@chromium.org, enric.balletbo@collabora.com, groeck@chromium.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev Subject: Re: [PATCH v3 1/1] platform/chrome: Poke kb_wake_angle attribute visibility when needed Message-ID: References: <20210804213139.4139492-1-gwendal@chromium.org> <20210804213139.4139492-2-gwendal@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 16, 2022 at 10:23:38AM -0800, Gwendal Grignou wrote: > [+chrome-platform@lists.linux.dev] Please also Cc to the mailing list if the patch gets chance to have next version. > On Mon, Nov 14, 2022 at 8:10 PM Gwendal Grignou wrote: [...] > > > Expose the attribute group to alter to close a potiential race between > > > cros-ec-sensorhub and cros-ec-sysfs (that creates the attribute group > > > on behalf of the class driver). I failed to realize the potential race. Could you explain it a bit? > > > diff --git a/include/linux/platform_data/cros_ec_proto.h b/include/linux/platform_data/cros_ec_proto.h > > > index 02599687770c5..c6dca260bbd5d 100644 > > > --- a/include/linux/platform_data/cros_ec_proto.h > > > +++ b/include/linux/platform_data/cros_ec_proto.h > > > @@ -191,6 +191,7 @@ struct cros_ec_platform { > > > /** > > > * struct cros_ec_dev - ChromeOS EC device entry point. > > > * @class_dev: Device structure used in sysfs. > > > + * @groups: sysfs attributes groups for this EC. The field name has extra "s".