From: Jiri Olsa <olsajiri@gmail.com>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next] samples: bpf: Use "grep -E" instead of "egrep"
Date: Fri, 18 Nov 2022 11:28:57 +0100 [thread overview]
Message-ID: <Y3deaZ+QxLqtj1Pp@krava> (raw)
In-Reply-To: <1668765001-12477-1-git-send-email-yangtiezhu@loongson.cn>
On Fri, Nov 18, 2022 at 05:50:01PM +0800, Tiezhu Yang wrote:
> The latest version of grep claims the egrep is now obsolete so the build
> now contains warnings that look like:
> egrep: warning: egrep is obsolescent; using grep -E
> fix this up by moving the related file to use "grep -E" instead.
>
> sed -i "s/egrep/grep -E/g" `grep egrep -rwl samples/bpf`
>
> Here are the steps to install the latest grep:
>
> wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz
> tar xf grep-3.8.tar.gz
> cd grep-3.8 && ./configure && make
> sudo make install
> export PATH=/usr/local/bin:$PATH
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Acked-by: Jiri Olsa <jolsa@kernel.org>
jirka
> ---
> samples/bpf/test_cgrp2_tc.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/bpf/test_cgrp2_tc.sh b/samples/bpf/test_cgrp2_tc.sh
> index 12faf58..395573b 100755
> --- a/samples/bpf/test_cgrp2_tc.sh
> +++ b/samples/bpf/test_cgrp2_tc.sh
> @@ -115,7 +115,7 @@ do_exit() {
> if [ "$DEBUG" == "yes" ] && [ "$MODE" != 'cleanuponly' ]
> then
> echo "------ DEBUG ------"
> - echo "mount: "; mount | egrep '(cgroup2|bpf)'; echo
> + echo "mount: "; mount | grep -E '(cgroup2|bpf)'; echo
> echo "$CGRP2_TC_LEAF: "; ls -l $CGRP2_TC_LEAF; echo
> if [ -d "$BPF_FS_TC_SHARE" ]
> then
> --
> 2.1.0
>
next prev parent reply other threads:[~2022-11-18 10:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 9:50 [PATCH bpf-next] samples: bpf: Use "grep -E" instead of "egrep" Tiezhu Yang
2022-11-18 10:28 ` Jiri Olsa [this message]
2022-11-18 23:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3deaZ+QxLqtj1Pp@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox