From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D938C43217 for ; Fri, 18 Nov 2022 16:08:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241839AbiKRQIe (ORCPT ); Fri, 18 Nov 2022 11:08:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235232AbiKRQIb (ORCPT ); Fri, 18 Nov 2022 11:08:31 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95D8EDF88 for ; Fri, 18 Nov 2022 08:08:30 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id o7so4895170pjj.1 for ; Fri, 18 Nov 2022 08:08:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=18v7itz8tcB+kulyiAhq7l9hrIOQNQ0hxN4rmyqP/Gk=; b=JyC6nE+T/Eqsnqr6iO3fk2MGx3PhxnyAJ8yPFlpQNleqYdGDrLGtkm2WiQ98CKRfyp CQM1ONo8/jAYTK0ab2Txj5wcwyJyRQWy1DhLJv8olXqny46AqhKzvtVFGMcyw8PxkZXa lD+uoEKhhvPOOBUlErzJwYK6AFifqlsYDd9N4jZwcnRDZ0PN8/CwoL281hM0fGrJgafp 1w7VVMsh7LbxAYkdRdkxu1Ze+yr+hR5saN/IeYFnsInZR43FQrRMqv7qkIF35cqbdQ35 A02vu3zgIBzDdOEk64IJAbwQUBidIS/MTiZ857aD4sCN/O6nVcT1znn9k7PECTInOVJi ZVNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=18v7itz8tcB+kulyiAhq7l9hrIOQNQ0hxN4rmyqP/Gk=; b=VXBNpatRUAcpAoYus378xr6preAIFkIB2xLjweYNLIohH8ASCF3rLvXdFH3osnJA+X 8ZZnzYV+WkTPsstmR/p4lJX+QffwxKkKvyAJOhLclk9775c0oYoKmxWaq9RSb6ON8Em/ K5aRNpd9ybJBYtUCwM0sp38I/j//qmKKjGmFQpSLm7KUbeBBPMsY4QD5w9/pdkAEwz8Y rZOc/ibjroMFKg/Lm2yHsXeH4kbWkj5lv2Veh3+gZSzMEPI4ga85+30XsHbvvlx9fUP0 k9oRAGwQl3q8nx5f7AUlSNweFUzqKjppt/JbqXSzZk7Hz1fbqalAgvOhN3wZVZw/W2fu XVZw== X-Gm-Message-State: ANoB5pmSN26mAWw/JSPJe8Ef6RxDNvbBpQBf4pKI/DB+w7n1dA9tk5R8 +07z4M2W3E4PNk/eGygHF34rXA== X-Google-Smtp-Source: AA0mqf6K5YJzlJyO+jeKg3SttZRxjLIf9dk/RpMi6fNcla3M+fffcQ1zcQBnZ61z9SCHc+dHaeaTaQ== X-Received: by 2002:a17:90a:ad4c:b0:212:c6f4:fa5 with SMTP id w12-20020a17090aad4c00b00212c6f40fa5mr8673553pjv.49.1668787710014; Fri, 18 Nov 2022 08:08:30 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id l7-20020a170902f68700b00177fb862a87sm3983255plg.20.2022.11.18.08.08.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 08:08:29 -0800 (PST) Date: Fri, 18 Nov 2022 16:08:25 +0000 From: Sean Christopherson To: Jiaxi Chen Cc: kvm@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, pbonzini@redhat.com, ndesaulniers@google.com, alexandre.belloni@bootlin.com, peterz@infradead.org, jpoimboe@kernel.org, chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com, babu.moger@amd.com, jmattson@google.com, sandipan.das@amd.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, fenghua.yu@intel.com, keescook@chromium.org, nathan@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/6] x86: KVM: Advertise AVX-IFMA CPUID to user space Message-ID: References: <20221118141509.489359-1-jiaxi.chen@linux.intel.com> <20221118141509.489359-4-jiaxi.chen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221118141509.489359-4-jiaxi.chen@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2022, Jiaxi Chen wrote: > AVX-IFMA is a new instruction in the latest Intel platform Sierra > Forest. This instruction packed multiplies unsigned 52-bit integers and > adds the low/high 52-bit products to Qword Accumulators. > > The bit definition: > CPUID.(EAX=7,ECX=1):EAX[bit 23] > > This CPUID is exposed to user space. Besides, there is no other VMX > control for this instruction. > > Signed-off-by: Jiaxi Chen > --- > arch/x86/include/asm/cpufeatures.h | 1 + > arch/x86/kvm/cpuid.c | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h > index df4a7f7505a9..159f8b9898bf 100644 > --- a/arch/x86/include/asm/cpufeatures.h > +++ b/arch/x86/include/asm/cpufeatures.h > @@ -310,6 +310,7 @@ > #define X86_FEATURE_AVX512_BF16 (12*32+ 5) /* AVX512 BFLOAT16 instructions */ > #define X86_FEATURE_CMPCCXADD (12*32+ 7) /* CMPccXADD instructions */ > #define X86_FEATURE_AMX_FP16 (12*32+21) /* AMX fp16 Support */ > +#define X86_FEATURE_AVX_IFMA (12*32+23) /* Support for VPMADD52[H,L]UQ */ > > /* AMD-defined CPU features, CPUID level 0x80000008 (EBX), word 13 */ > #define X86_FEATURE_CLZERO (13*32+ 0) /* CLZERO instruction */ > diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c > index 2a334d4cd04e..5726afb2d14c 100644 > --- a/arch/x86/kvm/cpuid.c > +++ b/arch/x86/kvm/cpuid.c > @@ -657,8 +657,8 @@ void kvm_set_cpu_caps(void) > kvm_cpu_cap_set(X86_FEATURE_SPEC_CTRL_SSBD); > > kvm_cpu_cap_mask(CPUID_7_1_EAX, > - F(AVX_VNNI) | F(AVX512_BF16) | F(CMPCCXADD) | F(AMX_FP16) > - ); > + F(AVX_VNNI) | F(AVX512_BF16) | F(CMPCCXADD) | F(AMX_FP16) | > + F(AVX_IFMA)); Please keep the terminating paranthesis+semicolon on a separate line. KVM isn't 100% consistent (as usual), but I would rather "fix" the cases that don't put the terminators on their own line.