From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81E70C433FE for ; Mon, 21 Nov 2022 21:44:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231890AbiKUVoi (ORCPT ); Mon, 21 Nov 2022 16:44:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231408AbiKUVoO (ORCPT ); Mon, 21 Nov 2022 16:44:14 -0500 Received: from us-smtp-delivery-44.mimecast.com (us-smtp-delivery-44.mimecast.com [205.139.111.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92C6D2675 for ; Mon, 21 Nov 2022 13:44:13 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-183-7uzm-LpVPkW4jNd1cgtn2g-1; Mon, 21 Nov 2022 16:42:50 -0500 X-MC-Unique: 7uzm-LpVPkW4jNd1cgtn2g-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 445C3811E84; Mon, 21 Nov 2022 21:42:49 +0000 (UTC) Received: from hog (unknown [10.39.192.162]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8047E492B16; Mon, 21 Nov 2022 21:42:47 +0000 (UTC) Date: Mon, 21 Nov 2022 22:41:57 +0100 From: Sabrina Dubroca To: Steffen Klassert Cc: syzbot , davem@davemloft.net, edumazet@google.com, herbert@gondor.apana.org.au, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, sfr@canb.auug.org.au, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] linux-next test error: general protection fault in xfrm_policy_lookup_bytype Message-ID: References: <000000000000706e6f05edfb4ce0@google.com> <20221121171513.GB704954@gauss3.secunet.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221121171513.GB704954@gauss3.secunet.de> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2022-11-21, 18:15:13 +0100, Steffen Klassert wrote: > On Mon, Nov 21, 2022 at 04:07:26PM +0100, Sabrina Dubroca wrote: > > 2022-11-21, 05:47:38 -0800, syzbot wrote: > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit: e4cd8d3ff7f9 Add linux-next specific files for 20221121 > > > git tree: linux-next > > > console output: https://syzkaller.appspot.com/x/log.txt?x=1472370d880000 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=a0ebedc6917bacc1 > > > dashboard link: https://syzkaller.appspot.com/bug?extid=bfb2bee01b9c01fff864 > > > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 > > > > > > Downloadable assets: > > > disk image: https://storage.googleapis.com/syzbot-assets/b59eb967701d/disk-e4cd8d3f.raw.xz > > > vmlinux: https://storage.googleapis.com/syzbot-assets/37a7b43e6e84/vmlinux-e4cd8d3f.xz > > > kernel image: https://storage.googleapis.com/syzbot-assets/ebfb0438e6a2/bzImage-e4cd8d3f.xz > > > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > > Reported-by: syzbot+bfb2bee01b9c01fff864@syzkaller.appspotmail.com > > > > > > general protection fault, probably for non-canonical address 0xdffffc0000000019: 0000 [#1] PREEMPT SMP KASAN > > > KASAN: null-ptr-deref in range [0x00000000000000c8-0x00000000000000cf] > > > CPU: 0 PID: 5295 Comm: kworker/0:3 Not tainted 6.1.0-rc5-next-20221121-syzkaller #0 > > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 > > > Workqueue: ipv6_addrconf addrconf_dad_work > > > RIP: 0010:xfrm_policy_lookup_bytype.cold+0x1c/0x54 net/xfrm/xfrm_policy.c:2139 > > > > That's the printk at the end of the function, when > > xfrm_policy_lookup_bytype returns NULL. It seems to have snuck into > > commit c39f95aaf6d1 ("xfrm: Fix oops in __xfrm_state_delete()"), we > > can just remove it: > > > > diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c > > index 3a203c59a11b..e392d8d05e0c 100644 > > --- a/net/xfrm/xfrm_policy.c > > +++ b/net/xfrm/xfrm_policy.c > > @@ -2135,9 +2135,6 @@ static struct xfrm_policy *xfrm_policy_lookup_bytype(struct net *net, u8 type, > > fail: > > rcu_read_unlock(); > > > > - if (!IS_ERR(ret)) > > - printk("xfrm_policy_lookup_bytype: policy if_id %d, wanted if_id %d\n", ret->if_id, if_id); > > - > > return ret; > > Hm, this was not in the original patch. Maybe my tree was not > clean when I applied it. Do you want to send a patch, or should > I just remove it? Go ahead, I guess it's more convenient for you. -- Sabrina