From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Alexey Romanov <avromanov@sberdevices.ru>,
minchan@kernel.org, senozhatsky@chromium.org, ngupta@vflare.org,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel@sberdevices.ru,
ddrokosov@sberdevices.ru
Subject: Re: [RFC PATCH v1 0/4] Introduce merge identical pages mechanism
Date: Tue, 22 Nov 2022 12:00:36 +0900 [thread overview]
Message-ID: <Y3w7VP5CKvm6XmoJ@google.com> (raw)
In-Reply-To: <Y3vjQ7VJYUEWl2uc@cmpxchg.org>
On (22/11/21 15:44), Johannes Weiner wrote:
> This looks pretty great.
>
> However, I'm curious why it's specific to zram, and not part of
> zsmalloc? That way zswap would benefit as well, without having to
> duplicate the implementation. This happened for example with
> page_same_filled() and zswap_is_page_same_filled().
>
> It's zsmalloc's job to store content efficiently, so couldn't this
> feature (just like the page_same_filled one) be an optimization that
> zsmalloc does transparently for all its users?
Yea, that's a much needed functionality, but things may be "complicated".
We had that KSM-ish thing in the past in zram. Very briefly as we quickly
found out that the idea was patented by some company in China and we couldn't
figure our if it was safe to land that code upstream. So we ended up dropping
the patches.
https://lore.kernel.org/lkml/1494556204-25796-1-git-send-email-iamjoonsoo.kim@lge.com/
> Would it make sense to hook this up to a shrinker?
Hmm, ratelimited perhaps. We most likely don't want to scan the whole pool
every time a shrinker calls us (which can be quite often).
next prev parent reply other threads:[~2022-11-22 3:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 19:00 [RFC PATCH v1 0/4] Introduce merge identical pages mechanism Alexey Romanov
2022-11-21 19:00 ` [RFC PATCH v1 1/4] zram: introduce " Alexey Romanov
2022-11-23 8:25 ` Chen Wandun
2022-11-23 9:04 ` Aleksey Romanov
2022-11-21 19:00 ` [RFC PATCH v1 2/4] zram: add merge sysfs knob Alexey Romanov
2022-11-21 19:00 ` [RFC PATCH v1 3/4] zram: add pages_merged counter to mm_stat Alexey Romanov
2022-11-21 19:00 ` [RFC PATCH v1 4/4] zram: recompression: add ZRAM_MERGED check Alexey Romanov
2022-11-21 20:44 ` [RFC PATCH v1 0/4] Introduce merge identical pages mechanism Johannes Weiner
2022-11-22 3:00 ` Sergey Senozhatsky [this message]
2022-11-22 3:07 ` Sergey Senozhatsky
2022-11-22 12:14 ` Aleksey Romanov
2022-11-23 4:13 ` Sergey Senozhatsky
2022-11-23 8:53 ` Dmitry Rokosov
2022-12-01 10:14 ` Dmitry Rokosov
2022-12-01 10:47 ` Sergey Senozhatsky
2022-12-01 11:14 ` Dmitry Rokosov
2022-12-01 13:29 ` Sergey Senozhatsky
2023-01-11 14:00 ` Alexey Romanov
2023-02-06 10:37 ` Sergey Senozhatsky
2022-11-23 9:07 ` Aleksey Romanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3w7VP5CKvm6XmoJ@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=avromanov@sberdevices.ru \
--cc=ddrokosov@sberdevices.ru \
--cc=hannes@cmpxchg.org \
--cc=kernel@sberdevices.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox