From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C54D3C4332F for ; Tue, 22 Nov 2022 12:09:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233582AbiKVMJC (ORCPT ); Tue, 22 Nov 2022 07:09:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232343AbiKVMIq (ORCPT ); Tue, 22 Nov 2022 07:08:46 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3069F2A71D for ; Tue, 22 Nov 2022 04:08:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0DD70B81A09 for ; Tue, 22 Nov 2022 12:08:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E080C433D6; Tue, 22 Nov 2022 12:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1669118914; bh=i1/B8KPOq23+jpieWztQH/1k9du0dfBH3YUJ5icWXhg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p5pt4jZNb0tafaiF3Oqmnp2OXIsR9giOzMApVEjLuUsPGiNAWtye6goFu2yhJr79V 5PNO2nrbA8KuUnfmXOVWEvT3bG8QucY2Fx3Tsq5aSewEVF2uaxYTAAa9Si0VYkmN7S uNZ9TOSry6g2zVi0RPJUIEDzodSy0YblvpYmleLE= Date: Tue, 22 Nov 2022 13:08:31 +0100 From: Greg Kroah-Hartman To: Deepak R Varma Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: pi433: call set_lan_gain for receiver config Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 19, 2022 at 10:41:17PM +0530, Deepak R Varma wrote: > Value for the LNA gain is captured from the user as part of the struct > pi433_rx_cfg, however, the corresponding function rf69_set_lna_gain() is > never called to set it. Include a call to this function as part of > setting up the rx configurations. > > Signed-off-by: Deepak R Varma > --- > drivers/staging/pi433/pi433_if.c | 3 +++ > 1 file changed, 3 insertions(+) How was this change tested? thanks, greg k-h