* [PATCH] iommu/amd: Fix typo in macro parameter name
@ 2022-11-22 22:18 Michael Forney
2022-11-24 4:51 ` Vasant Hegde
2022-12-05 10:48 ` Joerg Roedel
0 siblings, 2 replies; 3+ messages in thread
From: Michael Forney @ 2022-11-22 22:18 UTC (permalink / raw)
To: Joerg Roedel, iommu
Cc: Suravee Suthikulpanit, Will Deacon, Robin Murphy, linux-kernel,
Michael Forney
IVRS_GET_SBDF_ID is only called with fn as the fourth parameter,
so this had no effect, but fixing the name will avoid bugs if that
ever changes.
Signed-off-by: Michael Forney <mforney@mforney.org>
---
drivers/iommu/amd/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
index 1a2d425bf568..099ca3ed7d73 100644
--- a/drivers/iommu/amd/init.c
+++ b/drivers/iommu/amd/init.c
@@ -85,7 +85,7 @@
#define LOOP_TIMEOUT 2000000
-#define IVRS_GET_SBDF_ID(seg, bus, dev, fd) (((seg & 0xffff) << 16) | ((bus & 0xff) << 8) \
+#define IVRS_GET_SBDF_ID(seg, bus, dev, fn) (((seg & 0xffff) << 16) | ((bus & 0xff) << 8) \
| ((dev & 0x1f) << 3) | (fn & 0x7))
/*
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/amd: Fix typo in macro parameter name
2022-11-22 22:18 [PATCH] iommu/amd: Fix typo in macro parameter name Michael Forney
@ 2022-11-24 4:51 ` Vasant Hegde
2022-12-05 10:48 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Vasant Hegde @ 2022-11-24 4:51 UTC (permalink / raw)
To: Michael Forney, Joerg Roedel, iommu
Cc: Suravee Suthikulpanit, Will Deacon, Robin Murphy, linux-kernel
HI Michael,
On 11/23/2022 3:48 AM, Michael Forney wrote:
> IVRS_GET_SBDF_ID is only called with fn as the fourth parameter,
> so this had no effect, but fixing the name will avoid bugs if that
> ever changes.>
> Signed-off-by: Michael Forney <mforney@mforney.org>
Thanks for finding and fixing this issue.
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
-Vasant
> ---
> drivers/iommu/amd/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index 1a2d425bf568..099ca3ed7d73 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -85,7 +85,7 @@
>
> #define LOOP_TIMEOUT 2000000
>
> -#define IVRS_GET_SBDF_ID(seg, bus, dev, fd) (((seg & 0xffff) << 16) | ((bus & 0xff) << 8) \
> +#define IVRS_GET_SBDF_ID(seg, bus, dev, fn) (((seg & 0xffff) << 16) | ((bus & 0xff) << 8) \
> | ((dev & 0x1f) << 3) | (fn & 0x7))
>
> /*
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/amd: Fix typo in macro parameter name
2022-11-22 22:18 [PATCH] iommu/amd: Fix typo in macro parameter name Michael Forney
2022-11-24 4:51 ` Vasant Hegde
@ 2022-12-05 10:48 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2022-12-05 10:48 UTC (permalink / raw)
To: Michael Forney
Cc: iommu, Suravee Suthikulpanit, Will Deacon, Robin Murphy,
linux-kernel
On Tue, Nov 22, 2022 at 02:18:25PM -0800, Michael Forney wrote:
> IVRS_GET_SBDF_ID is only called with fn as the fourth parameter,
> so this had no effect, but fixing the name will avoid bugs if that
> ever changes.
>
> Signed-off-by: Michael Forney <mforney@mforney.org>
> ---
> drivers/iommu/amd/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-05 10:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-22 22:18 [PATCH] iommu/amd: Fix typo in macro parameter name Michael Forney
2022-11-24 4:51 ` Vasant Hegde
2022-12-05 10:48 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox