From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jack Schofield <schofija@oregonstate.edu>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: emxx_udc: Remove unneeded parentheses
Date: Mon, 5 Dec 2022 13:28:35 +0100 [thread overview]
Message-ID: <Y43j88qqo8K96TZL@kroah.com> (raw)
In-Reply-To: <20221128044012.GA2028@virt>
On Sun, Nov 27, 2022 at 08:40:12PM -0800, Jack Schofield wrote:
> Parentheses are not required around condition tests. Remove to follow
> Linux Kernel coding style. Issue reported by checkpatch.
>
> Signed-off-by: Jack Schofield <schofija@oregonstate.edu>
> ---
> There are more instances of extra parens to cleanup. If this patch is
> welcome I can continue to cleanup this file.
>
> drivers/staging/emxx_udc/emxx_udc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index b4e19174bef2..1d4ac8374fe2 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -149,8 +149,8 @@ static void _nbu2ss_ep0_complete(struct usb_ep *_ep, struct usb_request *_req)
> /* SET_FEATURE */
> recipient = (u8)(p_ctrl->bRequestType & USB_RECIP_MASK);
> selector = le16_to_cpu(p_ctrl->wValue);
> - if ((recipient == USB_RECIP_DEVICE) &&
> - (selector == USB_DEVICE_TEST_MODE)) {
> + if (recipient == USB_RECIP_DEVICE &&
> + selector == USB_DEVICE_TEST_MODE) {
> wIndex = le16_to_cpu(p_ctrl->wIndex);
> test_mode = (u32)(wIndex >> 8);
> _nbu2ss_set_test_mode(udc, test_mode);
> @@ -287,7 +287,7 @@ static int _nbu2ss_epn_exit(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep)
> u32 num;
> u32 data;
>
> - if ((ep->epnum == 0) || (udc->vbus_active == 0))
> + if (ep->epnum == 0 || udc->vbus_active == 0)
This type of change requires you to remember the == comes before || so
it's best to just leave the code as-is to make it much more obvious
what is happening.
sorry,
greg k-h
prev parent reply other threads:[~2022-12-05 12:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 4:40 [PATCH] staging: emxx_udc: Remove unneeded parentheses Jack Schofield
2022-12-05 12:28 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y43j88qqo8K96TZL@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=schofija@oregonstate.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox