public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ashok Raj <ashok.raj@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Borislav Petkov <bp@alien8.de>, X86-kernel <x86@kernel.org>,
	"LKML Mailing List" <linux-kernel@vger.kernel.org>,
	Dave Hansen <dave.hansen@intel.com>,
	Tony Luck <tony.luck@intel.com>, <alison.schofield@intel.com>,
	<reinette.chatre@intel.com>, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [Patch V1 7/7] x86/microcode/intel: Print when early microcode loading fails
Date: Mon, 5 Dec 2022 10:19:07 -0800	[thread overview]
Message-ID: <Y442GzMi1EE9SV5R@a4bf019067fa.jf.intel.com> (raw)
In-Reply-To: <87v8mtob6b.ffs@tglx>

On Fri, Dec 02, 2022 at 08:30:52PM +0100, Thomas Gleixner wrote:
> On Tue, Nov 29 2022 at 13:08, Ashok Raj wrote:
> 
> > Currently when early microcode loading fails there is no way for user to
> 
> the user
> 
> > know that the update failed.
> >
> > Store the failed status and pass it to print_ucode_info() to let early
> > loading failures to captured in console log.
> 
> so that early loading failures are captured in dmesg.
> 
> Hmm?

Thanks for the review Thomas. 

Boris, I have fixups to address all of Thomas's comments. Would you
like me to repost a new series with those fixups?

I'll drop patch1, since you have merged it in tip. You have a candidate for
patch2 as well, maybe I can drop that as well.

This patch has a type cast warning for 32bit compiles that I have fixed as
well.

I added a new patch to address Thomas's comment to print revs only when
loading succeeds[1].

Cheers,
Ashok

[1] https://lore.kernel.org/lkml/874judpqqd.ffs@tglx/

      reply	other threads:[~2022-12-05 18:19 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29 21:08 [Patch V1 0/7] x86/microcode: Some cleanups and fixes for microcode Ashok Raj
2022-11-29 21:08 ` [Patch V1 1/7] x86/microcode/intel: Remove redundant microcode rev pr_info()s Ashok Raj
2022-12-02 18:58   ` Thomas Gleixner
2022-12-03  0:26     ` Ashok Raj
2022-12-03 13:42       ` Borislav Petkov
2022-11-29 21:08 ` [Patch V1 2/7] x86/microcode/intel: Remove retries on early microcode load Ashok Raj
2022-12-02 19:01   ` Thomas Gleixner
2022-12-03  1:48     ` Ashok Raj
2022-12-02 23:53   ` Sohil Mehta
2022-12-03  1:47     ` Ashok Raj
2022-12-05 12:18   ` Borislav Petkov
2022-12-05 16:42     ` Ashok Raj
2022-12-05 20:53   ` [tip: x86/microcode] x86/microcode/intel: Do not retry microcode reloading on the APs tip-bot2 for Ashok Raj
2022-11-29 21:08 ` [Patch V1 3/7] x86/microcode/core: Move microcode_check() to cpu/microcode/core.c Ashok Raj
2022-12-02 19:02   ` Thomas Gleixner
2022-12-02 20:57   ` Sohil Mehta
2022-12-03  0:21     ` Ashok Raj
2022-12-05 16:25   ` Borislav Petkov
2022-12-05 17:05     ` Ashok Raj
2022-12-05 21:27       ` Borislav Petkov
2022-11-29 21:08 ` [Patch V1 4/7] x86/microcode/core: Take a snapshot before and after applying microcode Ashok Raj
2022-12-02 19:09   ` Thomas Gleixner
2022-12-03  1:57     ` Ashok Raj
2022-12-07 20:25   ` Borislav Petkov
2022-12-08  0:05     ` Ashok Raj
2022-11-29 21:08 ` [Patch V1 5/7] x86/microcode/intel: Prepare the print_ucode_rev to simply take a rev to print Ashok Raj
2022-12-02 19:23   ` Thomas Gleixner
2022-11-29 21:08 ` [Patch V1 6/7] x86/microcode/intel: Print old and new rev during early boot Ashok Raj
2022-12-02 19:29   ` Thomas Gleixner
2022-11-29 21:08 ` [Patch V1 7/7] x86/microcode/intel: Print when early microcode loading fails Ashok Raj
2022-12-02 19:30   ` Thomas Gleixner
2022-12-05 18:19     ` Ashok Raj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y442GzMi1EE9SV5R@a4bf019067fa.jf.intel.com \
    --to=ashok.raj@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox